Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add an ESLint rule to prohibit direct API client usage #143923

Open
xcrzx opened this issue Oct 25, 2022 · 2 comments
Open

[Security Solution] Add an ESLint rule to prohibit direct API client usage #143923

xcrzx opened this issue Oct 25, 2022 · 2 comments
Labels
Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Oct 25, 2022 •
edited
Loading

Related to: #136962

Summary

After migrating all API calls in the Rules Area to react-query, we need to ensure that all data queries or server state mutations happen through hooks defined in the detection_engine/rule_management/api/hooks folder exclusively. That is needed to ensure data cached on the front end side gets properly invalidated after mutations.

  • Extract all API methods unrelated to the Rules Area from detection_engine/rule_management/api/api.ts to their own areas
  • Migrate all remaining API methods that don't have corresponding react-query hooks, if there are any
  • Allow access detection_engine/rule_management/api/api.ts only from hooks defined in detection_engine/rule_management/api/hooks.
@xcrzx xcrzx added triage_needed technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Oct 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx mentioned this issue Oct 25, 2022
Closed
@banderror banderror added the Feature:Rule Management Security Solution Detection Rule Management area label Oct 25, 2022
This was referenced Nov 1, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xcrzx @banderror @elasticmachine