Shared data view in Saved Objects view shows space avatars for spaces that don't have one

[valscion]

Kibana version: v8.4.1

Elasticsearch version: v8.4.1

Server OS version: Elastic Cloud hosted

Browser version: Mozilla Firefox v104.0.2 (also happens with Google Chrome)

Browser OS version: N/A

Original install method (e.g. download page, yum, from source, etc.): Elastic Cloud installation

Describe the bug: A shared data view "Saved Objects" view shows space avatars for spaces that don't have one, making the UI appear a bit broken.

Steps to reproduce:

1. Create two spaces
2. Add an avatar image for the first space while keeping the later space without one
3. Share a data view between these two spaces
4. Go to "Saved Objects" view

Expected behavior: The avatar image would only be displayed for the space that has an image

Screenshots (if relevant):

Errors in browser console (if relevant): N/A

Provide logs and/or server output (if relevant): N/A

Any additional context: It seems that the <div class="euiAvatar ...> elements erroneusly have the background-image set for those spaces which should not have one, as per this screenshot from Google Chrome element inspector view:

By the way, sharing a data view between different spaces is awesome!

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[pgayvallet]

We have an image set for this space.

Obligatory question, Is that a bulbasaur?

@elastic/kibana-security it may have changed, so just to be sure: is the space list widget used by the SOM page under our or your ownership?

[pgayvallet]

Unless I'm mistaken it still lives in the spaces plugin.

kibana/src/plugins/saved_objects_management/public/services/columns/share_saved_objects_to_space_column.tsx

Line 90 in 3730dd0

const LazySpaceList = useMemo(() => spacesApiUi.components.getSpaceList, [spacesApiUi]);

kibana/x-pack/plugins/spaces/public/ui_api/components.tsx

Line 54 in 3730dd0

getSpaceList: wrapLazy(getSpaceListComponent),

[valscion]

Obligatory question, Is that a bulbasaur?

Oh that's a derpy Venusaur (https://imgur.com/x4ECDiR), we use it as a mascot of our development team and our bot account we usually call "Venuusaur" (as our company is named Venuu) 😅

[thomheymann]

This is a bug in EuiAvatar component which mutates its style prop: https://github.com/elastic/eui/blob/main/src/components/avatar/avatar.tsx#L144-L168

I have raised an issue here: elastic/eui#6249

[legrego]

It looks like elastic/eui#6249 has landed. @thomheymann, can you verify that this fix resolved our issue?

[valscion]

I've also been meaning to upgrade our stack to latest version so I could verify if this has been fixed but I haven't yet had the time to do it

[thomheymann]

This issue has been fixed by #141279