Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add ad-hoc data views to saved searches #139543

Closed
7 of 8 tasks
kertal opened this issue Aug 26, 2022 · 2 comments
Closed
7 of 8 tasks

[Discover] Add ad-hoc data views to saved searches #139543

kertal opened this issue Aug 26, 2022 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Aug 26, 2022

When #138283 is done, it is possible to create an ad hoc data view in Discover, but there are still several actions that require a persisted data view. Users should be enabled to save an ad hoc data view with a saved search.

While the basic code to enable saving the save search with the ad hoc one should be straight forward (don't show the dialog), the following task need to be checked

  • When loading a saved search with an add hoc data view it should be selected in the data view picker

  • Make sure ad-hoc contained saved search work like normal ones (except for actions where the users have to confirm to persist)

    • Discover incl. surrounding docs + single doc view should work
    • Saved searches on dashboard should work
    • Metric based Visualizations currently display "Search not found" - this has to be investigated, depending on the effort it might make sense to not allow creating such visualizations with ad-hoc data views, and fix it in a follow up PR
  • Once a saved search is duplicated (saved as a new saved search), the add hoc data view's id should get a new id

  • For features that currently don't work with an ad-hoc data view, and therefore the user has to confirm to create a "normal" data view, the id of the "normal" data view has to be a new one

  • There shall be functional tests, also for using such enhanced saved searches on dashboards

@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. 8.5 candidate labels Aug 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@timductive timductive added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Sep 8, 2022
@dimaanj
Copy link
Contributor

dimaanj commented Sep 16, 2022

Closing, since resolved by #138283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants