Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the need for 10 seconds delays after multiple saved_objects tests #130240

Closed
gsoldevila opened this issue Apr 14, 2022 · 4 comments · Fixed by #187858
Closed

Investigate the need for 10 seconds delays after multiple saved_objects tests #130240

gsoldevila opened this issue Apr 14, 2022 · 4 comments · Fixed by #187858
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@gsoldevila
Copy link
Contributor

gsoldevila commented Apr 14, 2022 •
edited
Loading

Multiple tests within the src/core/server/saved_objects folder have a 10 second delay at the es.stop() step, define on theafterEach() and afterAll() hooks.

image

image

The purpose is not clear, but it seems like an attempt to overcome problems that may arise if ES is not completely stopped (e.g. still holding some open handles or resources).

If we find and solve the underlying problem, and remove these 10sec delays between tests... the whole set of tests will execute much faster.

Originally posted by @gsoldevila in #97222 (comment)
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 14, 2022
@gsoldevila gsoldevila added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 14, 2022
@gsoldevila gsoldevila assigned gsoldevila and unassigned gsoldevila Apr 14, 2022
@pgayvallet
Copy link
Contributor

Did anyone solve the mistery of the 10s teardown delay yet, or should we still keep it 😅 ?

@afharo
Copy link
Member

afharo commented May 15, 2024

Do you think it's fixed now that we handle all promises?

@pgayvallet
Copy link
Contributor

From my understanding, it was more a hack to work around the fact that ES could take some time to "terminate" even after the es.stop() promise resolved. But I could totally be wrong...

@pgayvallet pgayvallet added the technical debt Improvement of the software architecture and operational architecture label Jul 8, 2024
@pgayvallet pgayvallet mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get rid of the infamous 10s delay in Core's integration tests pgayvallet/kibana
4 participants
@pgayvallet @afharo @elasticmachine @gsoldevila