-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set #129057
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@michaelolo24 can you please confirm if the behaviour described here is expected? Thanks!! :) |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
No, it's not expected as the size of the table adjusts as expected when filters are applied. @deepikakeshav-qasource Is it always reproducible or does it happen intermittently? |
Hi @michaelolo24 , This issue is occurring intermittently!! Thanks!! |
Thank you @deepikakeshav-qasource! @chandlerprall this might be an issue with the resize observer? Would you like our team to dig into it or do you have bandwith? It's low priority if that helps |
@michaelolo24 I can take an initial look next week |
Great, thanks! |
I've not been able to reproduce this after multiple attempts in Chrome, Firefox, or Safari on both |
Hi @chandlerprall , We have tried to reproduce this issue today on 8.2.0 BC4 and it reproduced but inconsistently as we tried on 02 builds but on one build its occurred Please find the below testing details:
Screenshot Second Build Alerts.-.Kibana.-.Google.Chrome.2022-05-03.16-33-43.mp4Thanks!! |
@chandlerprall @deepikakeshav-qasource I can reproduce this consistently by throttling my cpu in Chrome |
Based on the bug not appearing at all with 0 throttling and triggering immediately with 6x cpu throttling, I think it might be related to the use of useState set functions being used in places like setTimeout, try/catch, etc that seems to be a problem all throughout kibana tbh. https://github.com/elastic/eui/blob/main/src/components/datagrid/utils/grid_height_width.ts#L180 https://medium.com/swlh/react-state-batch-update-b1b61bd28cd2 and similar to #131023 perhaps |
@kqualters-elastic @chandlerprall Another issue could also be the fact that the resizing-effect is only called once after 100ms. If the browser for some reason takes longer than that, the size will never adjust. I'm guessing a |
closing this issue as it is very old and not reproducible anymore |
Describe the bug
Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set
Build Details:
preconditions
Steps to Reproduce
Actual Result
Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set
Expected Result
Extra space should not be displayed under alerts table when alerts are less than the number to which pagination count is set
Screen-Shot
alerts.page.mp4
The text was updated successfully, but these errors were encountered: