Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set #129057

Closed
ghost opened this issue Mar 31, 2022 · 14 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@ghost
Copy link

ghost commented Mar 31, 2022

Describe the bug
Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set

Build Details:

Version: 8.2.0 SNAPSHOT
Commit:a743498436a863e142592cb535b43f44c448851a
Build:51431

preconditions

  1. Alerts should be created

Steps to Reproduce

  1. Navigate to Alerts page
  2. Scroll down the page
  3. Alerts should be less than the number to which pagination count is set
  4. Observe that Extra space is displaying under alerts table

Actual Result
Extra space is displaying under alerts table when alerts are less than the number to which pagination count is set

Expected Result
Extra space should not be displayed under alerts table when alerts are less than the number to which pagination count is set

Screen-Shot

alerts.page.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0 labels Mar 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost assigned MadameSheema Mar 31, 2022
@MadameSheema
Copy link
Member

@michaelolo24 can you please confirm if the behaviour described here is expected? Thanks!! :)

@MadameSheema MadameSheema removed their assignment Apr 6, 2022
@MadameSheema MadameSheema added Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team labels Apr 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24
Copy link
Contributor

michaelolo24 commented Apr 14, 2022

No, it's not expected as the size of the table adjusts as expected when filters are applied. @deepikakeshav-qasource Is it always reproducible or does it happen intermittently?

@michaelolo24 michaelolo24 added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Apr 14, 2022
@ghost
Copy link
Author

ghost commented Apr 15, 2022

Hi @michaelolo24 ,

This issue is occurring intermittently!!

Thanks!!

@michaelolo24
Copy link
Contributor

Thank you @deepikakeshav-qasource! @chandlerprall this might be an issue with the resize observer? Would you like our team to dig into it or do you have bandwith? It's low priority if that helps

@chandlerprall
Copy link
Contributor

@michaelolo24 I can take an initial look next week

@michaelolo24
Copy link
Contributor

Great, thanks!

@chandlerprall
Copy link
Contributor

I've not been able to reproduce this after multiple attempts in Chrome, Firefox, or Safari on both main and 8.2 branches. No matter how many rows I filter down to, nor the page size I set, I cannot get the grid to have extra height.

@ghost
Copy link
Author

ghost commented May 3, 2022

Hi @chandlerprall ,

We have tried to reproduce this issue today on 8.2.0 BC4 and it reproduced but inconsistently as we tried on 02 builds but on one build its occurred

Please find the below testing details:
Build Details:

Version : 8.2.0 BC4
Build : 52005
Commit : 9a5003d8cf0062bf24ef64d6712b44823888cc03

Screenshot

First Build
image (3)

image (4)

Second Build

Alerts.-.Kibana.-.Google.Chrome.2022-05-03.16-33-43.mp4

Thanks!!

@kqualters-elastic
Copy link
Contributor

@chandlerprall @deepikakeshav-qasource I can reproduce this consistently by throttling my cpu in Chrome
image

@kqualters-elastic
Copy link
Contributor

Based on the bug not appearing at all with 0 throttling and triggering immediately with 6x cpu throttling, I think it might be related to the use of useState set functions being used in places like setTimeout, try/catch, etc that seems to be a problem all throughout kibana tbh. https://github.com/elastic/eui/blob/main/src/components/datagrid/utils/grid_height_width.ts#L180 https://medium.com/swlh/react-state-batch-update-b1b61bd28cd2 and similar to #131023 perhaps

@janmonschke
Copy link
Contributor

@kqualters-elastic @chandlerprall Another issue could also be the fact that the resizing-effect is only called once after 100ms. If the browser for some reason takes longer than that, the size will never adjust. I'm guessing a setInterval that periodically checks for changes will lead to layout thrashing. I wonder what the useResizeObserver here is used for (https://github.com/elastic/eui/blob/805960c93333ecf6d46927a5cbe480a0232a6d55/src/components/datagrid/utils/grid_height_width.ts#L163). Is it used to re-evaluate the hook?

@PhilippeOberti
Copy link
Contributor

closing this issue as it is very old and not reproducible anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

7 participants