Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Monitoring settings doesn't mention service account tokens #124576

Closed
Tracked by #127224
jportner opened this issue Feb 3, 2022 · 3 comments
Closed
Tracked by #127224

[Docs] Monitoring settings doesn't mention service account tokens #124576

jportner opened this issue Feb 3, 2022 · 3 comments
Assignees
Labels
docs Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jportner
Copy link
Contributor

jportner commented Feb 3, 2022

The docs for Monitoring settings don't mention service account tokens.

In #102121, starting with the 7.15 release we added the ability to configure a service account token using elasticsearch.serviceAccountToken. By extension, you can configure a service account token for a separate Monitoring cluster using the monitoring.ui.elasticsearch.serviceAccountToken setting. The docs should reflect this.

@jportner jportner added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services docs labels Feb 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@neptunian
Copy link
Contributor

@jportner or @elastic/kibana-docs Should elasticsearch.serviceAccountToken still be marked as beta in current docs? I'm not sure how that's determined as I don't see in the docs where the corresponding ES API is marked as beta. I assume monitoring.ui.elasticsearch.serviceAccountToken should be the same.

@jportner
Copy link
Contributor Author

jportner commented Mar 23, 2022

@jportner or @elastic/kibana-docs Should elasticsearch.serviceAccountToken still be marked as beta in current docs? I'm not sure how that's determined as I don't see in the docs where the corresponding ES API is marked as beta. I assume monitoring.ui.elasticsearch.serviceAccountToken should be the same.

Great question.

We initially marked this setting as beta in our docs when we added this setting in 7.15 via #102121, here was our reasoning at the time:
Note I am marking this as beta in the docs because the underlying ES APIs are marked as beta. This gives us the necessary flexibility to make a breaking change if required (although I do not expect any at this time)

It looks like the API is marked as beta in the 7.13 docs, but it is not marked as beta in the 7.14 docs.

I will submit a PR to update our docs accordingly.

Edit: PR is here #128420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants