Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Numeric span labels are no longer displayed alongside string labels, need to scroll #124364

Closed
cyrille-leclerc opened this issue Feb 2, 2022 · 8 comments
Labels
apm:opentelemetry APM UI - OTEL Work Team:APM All issues that need APM UI Team support

Comments

@cyrille-leclerc
Copy link
Contributor

cyrille-leclerc commented Feb 2, 2022

Kibana version

8.0-rc1

Steps to Reproduce

Capture APM spans with numeric span labels (or Otel span attributes) added using span APIs.

Expected Behavior

Labels, whatever their type, are displayed in a sorted compact list.

Actual Behavior

Span numeric labels are no longer displayed alongside the string labels, the user needs to scroll down on the flyout.

image

@cyrille-leclerc cyrille-leclerc added the Team:APM All issues that need APM UI Team support label Feb 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

The metadata sections are sorted alphabetically, except for the "labels" section which is pinned to the top. Should we do the same with the "numeric_labels" section, or is the suggestion to merge it together with the "labels" section?

@formgeist
Copy link
Contributor

@sqren I reckon we should "pin" numeric_labels to the top after labels

@sorenlouv
Copy link
Member

Sounds good 👍

@cyrille-leclerc
Copy link
Contributor Author

Pinning seems to be a good step forward. I would love eventually to merge all the labels in the same alpha sorted buckets.
The fact that labels are split between numeric labels in one group and all other types in another group feels like an implementation detail to me.
By the way, in which group would I find an array of numeric or a date? These are questions I would be abstracted from.

Does it make sense?

@simitt
Copy link
Contributor

simitt commented Feb 10, 2022

Server side, there are no plans to consolidate numeric_labels with labels, we just separated them out to align better with ECS. Any kind of consolidation should be done on the UI side.
I agree that the concrete type can be considered an implementation detail, but given the limited amount of types we currently support - bool (labels), string (labels) and numeric values (numeric_labels) - and that there are no plans to extend this, pinning might be good enough for now.

@axw
Copy link
Member

axw commented Feb 11, 2022

++ agreed that this is an unfortunate, leaky implementation detail.

We hope to migrate labels.* to the flattened field type in the future. We could put numerical label values in flattened without having to worry about mapping conflicts, but flattened has limited supported operations. In particular, you wouldn't be able to do things like numerical range queries (range is supported, but the values are treated as strings).

@dannycroft dannycroft added the apm:opentelemetry APM UI - OTEL Work label May 31, 2022
@gbamparop
Copy link
Contributor

This is fixed by #151575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:opentelemetry APM UI - OTEL Work Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

8 participants