Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Package policy is invalid: required field, value empty string #123596

Closed
mtojek opened this issue Jan 24, 2022 · 4 comments · Fixed by #123610
Closed

[Fleet] Package policy is invalid: required field, value empty string #123596

mtojek opened this issue Jan 24, 2022 · 4 comments · Fixed by #123610
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0

Comments

@mtojek
Copy link
Contributor

mtojek commented Jan 24, 2022

Hi,

we suspect that something might have changed in Kibana. We have a system test, that uses a required field content_type and sets its value to an empty string (""). We noticed that the system test fails with:

[36mkibana_1                     |[0m [2022-01-24T04:55:38.557+00:00][ERROR][plugins.fleet] Package policy is invalid: inputs.http_endpoint.streams.ti_anomali.threatstream.vars.content_type: Webhook path is required

We also noticed that the last time the system test worked was 4 days ago. It means that there is a risk that a breaking change might have been introduced.

Would you mind taking a look?

@mtojek mtojek added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 24, 2022
@joshdover
Copy link
Contributor

Guessing this is related to #123261 which was just recently merged.

@joshdover
Copy link
Contributor

We need to accept empty strings as values for required fields to fix this, our lovely JavaScript programming language where empty strings are falsey is probably to blame here.

@joshdover joshdover added bug Fixes for quality problems that affect the customer experience v8.0.0 v8.1.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jan 24, 2022
@mtojek
Copy link
Contributor Author

mtojek commented Jan 25, 2022

Let's keep it open until we confirm it's fixed.

@mtojek
Copy link
Contributor Author

mtojek commented Jan 28, 2022

I confirmed that the issue is fixed. Thanks for taking care of this folks!

@mtojek mtojek closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants