Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing resize-observer-polyfill #121509

Open
1 of 5 tasks
Dosant opened this issue Dec 17, 2021 · 3 comments
Open
1 of 5 tasks

Consider removing resize-observer-polyfill #121509

Dosant opened this issue Dec 17, 2021 · 3 comments
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort old Used to help sort old issues on GH Projects which don't support the Created search term. performance Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 17, 2021 •
edited by weltenwort
Loading

Is looks like we can safely remove resize-observer-polyfill and shave dozens of Kbs from bunch of async chunks:

  • x-pack/plugins/security_solution/public/resolver/types.ts @elastic/security-solution
  • x-pack/plugins/security_solution/public/resolver/view/side_effect_context.ts @elastic/security-solution
  • [Infra UI] Remove dependence on ResizeObserver polyfill #122022
    • (x-pack/plugins/infra/public/components/auto_sizer.tsx @elastic/infra-monitoring-ui)
  • src/plugins/kibana_utils/public/resize_checker/resize_checker.ts @elastic/kibana-app-services
  • src/plugins/kibana_utils/public/resize_checker/resize_checker.test.ts @elastic/kibana-app-services

In some places we already use ResizeObserver without a polyfill, e.g. x-pack/plugins/security_solution/public/resolver/view/use_camera.ts
@Dosant Dosant added performance technical debt Improvement of the software architecture and operational architecture Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:AppServicesUx labels Dec 17, 2021
This was referenced Dec 17, 2021
Merged
Closed
@janmonschke
Copy link
Contributor

Sounds like a great initiative to me 👏

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 20, 2021
@weltenwort weltenwort mentioned this issue Dec 27, 2021
Closed
@lizozom
Copy link
Contributor

lizozom commented Apr 18, 2022

Sounds like a small and useful thing to do, especially as we try to reduce bundle sizes.
Why not tackle this?

@miltonhultgren miltonhultgren removed the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jun 23, 2023
@vadimkibana vadimkibana added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:AppServicesUx labels Jan 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort old Used to help sort old issues on GH Projects which don't support the Created search term. performance Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@janmonschke @miltonhultgren @lizozom @Dosant @elasticmachine @petrklapka @vadimkibana