Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] - T Grid always show the leading checkboxes #119482

Closed
fkanout opened this issue Nov 23, 2021 · 1 comment · Fixed by #119608
Closed

[RAC] - T Grid always show the leading checkboxes #119482

fkanout opened this issue Nov 23, 2021 · 1 comment · Fixed by #119608
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete

Comments

@fkanout
Copy link
Contributor

fkanout commented Nov 23, 2021

Summery

T Grid provides the possibility to hide the leading checkBoxes in the table, and it is configurable via a prop showCheckBoxes with a boolean value. However, this value is hardcoded with true, which means the checkboxes always appear whatever value is passed.

Hiding leading checkboxes required in this issue, so I tried to fix it with showCheckboxes: leadingControlColumns[0].showCheckboxes ?? true,
That fulfilled my requirement, but, unfortunately, it made other tests for other components fail.

AC

  • Remove the hard-coded value true and make showCheckBoxes prop configurable.
  • Update/Fix the related tests
@fkanout fkanout added bug Fixes for quality problems that affect the customer experience Theme: rac label obsolete Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 23, 2021
@kqualters-elastic
Copy link
Contributor

I would suggest solving this like this
no_checkboxes.patch.txt
this way the prop is exposed to use with false, but defaults to true unless specified so that existing tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants