Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] ensureDefaultDataView needs separation between UI and business logic #112846

Closed
1 task
mattkime opened this issue Sep 22, 2021 · 1 comment · Fixed by #113891
Closed
1 task

[data views] ensureDefaultDataView needs separation between UI and business logic #112846

mattkime opened this issue Sep 22, 2021 · 1 comment · Fixed by #113891
Assignees
@mattkime
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort v7.16.0 v8.0.0

Comments

@mattkime
Copy link
Contributor

dataViews.ensureDefaultDataView does two things - it ensures there's a default dataView (as named) BUT it also redirects if there's no data views at all.

  • Provide a 'dataViews.getDefaultDataView' method which grabs the default data view. If there isn't one OR the saved object no longer exists, select another data view and make it the default. Failing that, return undefined.

The redirect behavior can be implemented with existing core functionality.

Addresses #112362
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 Team:AppServices v7.16.0 labels Sep 22, 2021
@mattkime mattkime self-assigned this Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Sep 22, 2021
@mattkime mattkime mentioned this issue Oct 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data views] add getDefaultDataView method mattkime/kibana
2 participants
@mattkime @elasticmachine