Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test to ensure the SavedObjectsRepository handles responses correctly #107246

Closed
TinaHeiligers opened this issue Jul 29, 2021 · 3 comments · Fixed by #109755
Closed
Labels
Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0

Comments

@TinaHeiligers
Copy link
Contributor

In #107104 we added functionality to determine if 404 responses are a result of saved object documents not being found or some other cause where the response can't be verified to have come from Elasticsearch.

As we implement the differentiation more broadly in all the repository calls to ES, we need to ensure the behavior is consistent.

Adding an integration test would be great but is not simple to do because we'd need to setup a proxy server in front of Elasticsearch that allows us to 'hi-jack' the response to test the condition.

Suggested Implementation

We should experiment with using a custom Hapi server with the h2o2 pluging (the same one we use for the base path proxy).

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects v7.15.0 labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

@elastic/kibana-operations can you give any guidance here?

@tylersmalley
Copy link
Contributor

tylersmalley commented Aug 2, 2021

I have created #107422 to track, but anyone should be able to help out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants