Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SO Migration v2] Remove the OUTDATED_DOCUMENTS_* steps #103731

Closed
pgayvallet opened this issue Jun 29, 2021 · 3 comments
Closed

[SO Migration v2] Remove the OUTDATED_DOCUMENTS_* steps #103731

pgayvallet opened this issue Jun 29, 2021 · 3 comments
Labels
Feature:Migrations loe:medium Medium Level of Effort project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

Now that

  1. we're performing a client-side reindex during the source to temp copy Rewriting SO id during migration #97222
  2. Are officially no longer supporting migrating unknown document types (SO migration v2: fail the migration early if unknown types are encountered #101351)

It seems there is no longer any need to perform the outdated document search and update in the target index.

We need to make sure that these steps no longer make any sense, and if so, we should remove them.
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient labels Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

This was referenced Jun 29, 2021
Merged
Closed
@joshdover joshdover mentioned this issue Aug 5, 2021
Closed
6 tasks
@rudolf
Copy link
Contributor

rudolf commented Feb 8, 2022 •
edited
Loading

I agree that the OUTDATED_DOCUMENTS_* and also the UPDATE_TARGET_MAPPINGS steps are no longer necessary. Especially the UPDATE_TARGET_MAPPINGS step can sometimes take quite long on a busy cluster with many documents, so this could reduce failures and improve performance.

@planadecu planadecu added the loe:medium Medium Level of Effort label Feb 8, 2022
@pgayvallet
Copy link
Contributor Author

This was indirectly taken care of via the same-index-reindex enhancement. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Migrations loe:medium Medium Level of Effort project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@planadecu @rudolf @pgayvallet @elasticmachine