Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Allow Rendering of By Value Embeddables #101628

Closed
crob611 opened this issue Jun 8, 2021 · 1 comment · Fixed by #113827
Closed

[Canvas] Allow Rendering of By Value Embeddables #101628

crob611 opened this issue Jun 8, 2021 · 1 comment · Fixed by #113827
Assignees
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@crob611
Copy link
Contributor

crob611 commented Jun 8, 2021

The current Embeddable Renderer expects an Id on its input that it will use to load a saved object by id. This won't work for rendering embeddables byValue. The renderer should be updated to just pass in the config to factory.create instead of calling createFromSavedObject.

This renderer should be pulled out of Canvas and registered as it's own expression_embeddable plugin that can live in src instead of in x-pack.

@crob611 crob611 added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 self-assigned this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants