Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI] Replace all alerting components direct file references with triggersActionsUI plugin setup/start contracts. #101297

Open
YulNaumenko opened this issue Jun 3, 2021 · 1 comment
Open

[Alerting UI] Replace all alerting components direct file references with triggersActionsUI plugin setup/start contracts. #101297

YulNaumenko opened this issue Jun 3, 2021 · 1 comment
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting performance Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@YulNaumenko
Copy link
Contributor

YulNaumenko commented Jun 3, 2021 •
edited
Loading

Currently we have a couple of places where we exposed alerting components for the usage by external plugins (Cases, Security, others):
export { getServiceNowITSMActionType, getServiceNowSIRActionType,} from '../application/components/builtin_action_types/servicenow';export { getJiraActionType } from '../application/components/builtin_action_types/jira';export { getResilientActionType } from '../application/components/builtin_action_types/resilient'; Fixed in the PR

Remove non used imports from x-pack/plugins/triggers_actions_ui/public/index.ts
change ActionForm, AlertConditions, AlertConditionsGroup to be exposed through the plugin start contract and remove direct component links from Security plugin.

This changes will help to reduce the plugin bundle size as well:
Screen Shot 2021-06-02 at 10 50 08 PM
Screen Shot 2021-06-02 at 10 51 38 PM
@YulNaumenko YulNaumenko added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko linked a pull request Jun 3, 2021 that will close this issue
[Alerting UI] Replace direct components links in Cases plugin with the actionsTypeRegistry exposed by the triggersActionsUi plugin setup contract #100442
Closed
9 tasks
@cnasikas cnasikas assigned cnasikas and unassigned cnasikas Jun 7, 2021
@gmmorris gmmorris added Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. performance labels Jun 30, 2021
@gmmorris gmmorris added the loe:medium Medium Level of Effort label Jul 15, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting performance Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: No status
Milestone
No milestone
5 participants
@gmmorris @kobelb @cnasikas @elasticmachine @YulNaumenko