From f6060852109410ba028e21d679206147cbd1a011 Mon Sep 17 00:00:00 2001
From: Thomas Neirynck <thomas@elastic.co>
Date: Wed, 10 Jan 2024 10:34:00 -0500
Subject: [PATCH] [SO] remove some plugin dependencies (#174282)

## Summary

Removes some `savedObject` plugin dependencies.

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 examples/portable_dashboards_example/kibana.jsonc | 1 -
 src/plugins/controls/kibana.jsonc                 | 1 -
 src/plugins/dashboard/public/plugin.tsx           | 2 --
 src/plugins/visualizations/kibana.jsonc           | 4 ++--
 x-pack/plugins/maps/kibana.jsonc                  | 4 ++--
 5 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/examples/portable_dashboards_example/kibana.jsonc b/examples/portable_dashboards_example/kibana.jsonc
index e4016f2b1c01e..d6fd1a82e1df5 100644
--- a/examples/portable_dashboards_example/kibana.jsonc
+++ b/examples/portable_dashboards_example/kibana.jsonc
@@ -16,7 +16,6 @@
       "dashboard",
       "embeddable",
       "navigation",
-      "savedObjects",
       "unifiedSearch",
       "developerExamples",
       "embeddableExamples"
diff --git a/src/plugins/controls/kibana.jsonc b/src/plugins/controls/kibana.jsonc
index 0defa22bd351f..14718f533a8f6 100644
--- a/src/plugins/controls/kibana.jsonc
+++ b/src/plugins/controls/kibana.jsonc
@@ -9,7 +9,6 @@
     "browser": true,
     "requiredPlugins": [
       "presentationUtil",
-      "savedObjects",
       "kibanaReact",
       "expressions",
       "embeddable",
diff --git a/src/plugins/dashboard/public/plugin.tsx b/src/plugins/dashboard/public/plugin.tsx
index 4c75362485b6a..8fb1260eb327d 100644
--- a/src/plugins/dashboard/public/plugin.tsx
+++ b/src/plugins/dashboard/public/plugin.tsx
@@ -34,7 +34,6 @@ import type { SpacesPluginStart } from '@kbn/spaces-plugin/public';
 import type { HomePublicPluginSetup } from '@kbn/home-plugin/public';
 import { replaceUrlHashQuery } from '@kbn/kibana-utils-plugin/common';
 import { createKbnUrlTracker } from '@kbn/kibana-utils-plugin/public';
-import type { SavedObjectsStart } from '@kbn/saved-objects-plugin/public';
 import type { VisualizationsStart } from '@kbn/visualizations-plugin/public';
 import type { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';
 import type { NavigationPublicPluginStart } from '@kbn/navigation-plugin/public';
@@ -96,7 +95,6 @@ export interface DashboardStartDependencies {
   inspector: InspectorStartContract;
   navigation: NavigationPublicPluginStart;
   presentationUtil: PresentationUtilPluginStart;
-  savedObjects: SavedObjectsStart;
   contentManagement: ContentManagementPublicStart;
   savedObjectsManagement: SavedObjectsManagementPluginStart;
   savedObjectsTaggingOss?: SavedObjectTaggingOssPluginStart;
diff --git a/src/plugins/visualizations/kibana.jsonc b/src/plugins/visualizations/kibana.jsonc
index 69caa82b50030..9d1c6c1da0e58 100644
--- a/src/plugins/visualizations/kibana.jsonc
+++ b/src/plugins/visualizations/kibana.jsonc
@@ -17,7 +17,6 @@
       "navigation",
       "embeddable",
       "inspector",
-      "savedObjects",
       "screenshotMode",
       "presentationUtil",
       "dataViews",
@@ -40,7 +39,8 @@
     "requiredBundles": [
       "kibanaUtils",
       "kibanaReact",
-      "charts"
+      "charts",
+      "savedObjects",
     ],
     "extraPublicDirs": [
       "common/constants",
diff --git a/x-pack/plugins/maps/kibana.jsonc b/x-pack/plugins/maps/kibana.jsonc
index b6bf08329fb44..fb0472100e1c2 100644
--- a/x-pack/plugins/maps/kibana.jsonc
+++ b/x-pack/plugins/maps/kibana.jsonc
@@ -27,7 +27,6 @@
       "dashboard",
       "embeddable",
       "mapsEms",
-      "savedObjects",
       "share",
       "presentationUtil",
       "contentManagement"
@@ -50,7 +49,8 @@
       "usageCollection",
       "unifiedSearch",
       "fieldFormats",
-      "textBasedLanguages"
+      "textBasedLanguages",
+      "savedObjects",
     ],
     "extraPublicDirs": [
       "common"