From eb187af1967c2965329b7e0daf7a21d46abf023d Mon Sep 17 00:00:00 2001 From: Diana Derevyankina Date: Tue, 13 Jul 2021 01:03:40 +0300 Subject: [PATCH] Update filter ratio setting numerator denominator function --- test/functional/apps/visualize/_tsvb_table.ts | 6 ++---- test/functional/page_objects/visual_builder_page.ts | 13 ++++++++----- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts index 132e913c13997..97d5488bf8c34 100644 --- a/test/functional/apps/visualize/_tsvb_table.ts +++ b/test/functional/apps/visualize/_tsvb_table.ts @@ -92,10 +92,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { it('should display correct values for filter ratio aggregation with numerator and denominator', async () => { const EXPECTED = 'OS Filter Ratio\nwin 8 2\nwin xp 0\nwin 7 3\nios 0\nosx 0'; await visualBuilder.selectAggType('Filter Ratio'); - await visualBuilder.setFilterRatioNumeratorDenominator( - 'extension.raw : "css"', - 'bytes <= 3000' - ); + await visualBuilder.setFilterRatioNumerator('extension.raw : "css"'); + await visualBuilder.setFilterRatioDenominator('bytes <= 3000'); await visChart.waitForVisualizationRenderingStabilized(); const tableData = await visualBuilder.getViewTable(); diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index 4b3f282e498dc..d3f81dc043706 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -728,14 +728,17 @@ export class VisualBuilderPageObject extends FtrService { }); } - public async setFilterRatioNumeratorDenominator( - numerator: string = '', - denominator: string = '' - ) { - const [numeratorInput, denominatorInput] = await this.find.allByCssSelector( + public async setFilterRatioNumerator(numerator: string) { + const numeratorInput = await this.find.byCssSelector( '.tvbAggRow [data-test-subj="queryInput"]' ); await numeratorInput.type(numerator); + } + + public async setFilterRatioDenominator(denominator: string) { + const [, denominatorInput] = await this.find.allByCssSelector( + '.tvbAggRow [data-test-subj="queryInput"]' + ); await denominatorInput.type(denominator); } }