From d70767917a43fc51f854b95e1249a271d22b5eb1 Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Fri, 11 Jan 2019 16:33:16 -0700 Subject: [PATCH] [kbn-number-list] avoid adding new items that are outside of the range (#28304) * dont add value outside of range * handle last being over max * return NaN for next when list is empty --- src/ui/public/number_list/number_list.js | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/ui/public/number_list/number_list.js b/src/ui/public/number_list/number_list.js index 0234d7230527b..1102cae032cea 100644 --- a/src/ui/public/number_list/number_list.js +++ b/src/ui/public/number_list/number_list.js @@ -88,7 +88,22 @@ uiModules const list = self.getList(); if (!list) return; - list.push(_.last(list) + 1); + function getNext() { + if (list.length === 0) { + // returning NaN adds an empty input + return NaN; + } + + const next = _.last(list) + 1; + if (next < self.range.max) { + return next; + } + + return self.range.max - 1; + } + + const next = getNext(); + list.push(next); }; /**