review feedback

elastic · Sep 16, 2020 · a1317a5 · a1317a5
1 parent 43438c3
commit a1317a5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/x-pack/examples/ui_actions_enhanced_examples/.eslintrc.json b/x-pack/examples/ui_actions_enhanced_examples/.eslintrc.json
@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "@typescript-eslint/consistent-type-definitions": 0
+  }
+}
diff --git a/...ck/examples/ui_actions_enhanced_examples/public/dashboard_hello_world_drilldown/index.tsx b/...ck/examples/ui_actions_enhanced_examples/public/dashboard_hello_world_drilldown/index.tsx
@@ -17,7 +17,6 @@ import {
 
 export type ActionContext = ChartActionContext;
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 export type Config = {
   name: string;
 };

diff --git a/...ions_enhanced_examples/public/dashboard_hello_world_only_range_select_drilldown/index.tsx b/...ions_enhanced_examples/public/dashboard_hello_world_only_range_select_drilldown/index.tsx
@@ -13,7 +13,6 @@ import { CollectConfigProps } from '../../../../../src/plugins/kibana_utils/publ
 import { SELECT_RANGE_TRIGGER } from '../../../../../src/plugins/ui_actions/public';
 import { BaseActionFactoryContext } from '../../../../plugins/ui_actions_enhanced/public/dynamic_actions';
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 export type Config = {
   name: string;
 };

diff --git a/x-pack/examples/ui_actions_enhanced_examples/public/dashboard_to_discover_drilldown/types.ts b/x-pack/examples/ui_actions_enhanced_examples/public/dashboard_to_discover_drilldown/types.ts
@@ -9,7 +9,6 @@ import { ApplyGlobalFilterActionContext } from '../../../../../src/plugins/data/
 
 export type ActionContext = ApplyGlobalFilterActionContext;
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 export type Config = {
   /**
    * Whether to use a user selected index pattern, stored in `indexPatternId` field.

diff --git a/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/types.ts b/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/types.ts
@@ -4,7 +4,6 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-// eslint-disable-next-line
 export type UrlDrilldownConfig = {
   url: { format?: 'handlebars_v1'; template: string };
   openInNewTab: boolean;