[ML] Data Frame Analytics: Support early stopping data frame analytic…

…s job parameter (#90695) (#90840) * add support for early_stopping_enabled in cloning * remove obsolete comment
elastic · Feb 9, 2021 · 8ddbaba · 8ddbaba
1 parent 277fe42
commit 8ddbaba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/..._frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx b/..._frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx
@@ -117,6 +117,10 @@ const getAnalyticsJobMeta = (config: CloneDataFrameAnalyticsConfig): AnalyticsJo
               optional: true,
               defaultValue: 'maximize_minimum_recall',
             },
+            early_stopping_enabled: {
+              optional: true,
+              ignore: true,
+            },
           },
         }
       : {}),
@@ -207,6 +211,10 @@ const getAnalyticsJobMeta = (config: CloneDataFrameAnalyticsConfig): AnalyticsJo
             loss_function_parameter: {
               optional: true,
             },
+            early_stopping_enabled: {
+              optional: true,
+              ignore: true,
+            },
           },
         }
       : {}),

diff --git a/.../data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts b/.../data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts
@@ -56,6 +56,7 @@ export interface State {
     destinationIndexNameEmpty: boolean;
     destinationIndexNameValid: boolean;
     destinationIndexPatternTitleExists: boolean;
+    earlyStoppingEnabled: undefined | boolean;
     eta: undefined | number;
     featureBagFraction: undefined | number;
     featureInfluenceThreshold: undefined | number;
@@ -125,6 +126,7 @@ export const getInitialState = (): State => ({
     destinationIndexNameEmpty: true,
     destinationIndexNameValid: false,
     destinationIndexPatternTitleExists: false,
+    earlyStoppingEnabled: undefined,
     eta: undefined,
     featureBagFraction: undefined,
     featureInfluenceThreshold: undefined,
@@ -239,7 +241,10 @@ export const getJobConfigFromFormState = (
       formState.gamma && { gamma: formState.gamma },
       formState.lambda && { lambda: formState.lambda },
       formState.maxTrees && { max_trees: formState.maxTrees },
-      formState.randomizeSeed && { randomize_seed: formState.randomizeSeed }
+      formState.randomizeSeed && { randomize_seed: formState.randomizeSeed },
+      formState.earlyStoppingEnabled !== undefined && {
+        early_stopping_enabled: formState.earlyStoppingEnabled,
+      }
     );
 
     jobConfig.analysis = {

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts
@@ -15,8 +15,7 @@ export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
   const ml = getService('ml');
 
-  // Failing ES promotion, see https://github.com/elastic/kibana/issues/89980
-  describe.skip('jobs cloning supported by UI form', function () {
+  describe('jobs cloning supported by UI form', function () {
     const testDataList: Array<{
       suiteTitle: string;
       archive: string;