From 828a5790e4b16ad13bd5cf2367e2082a24ad3c21 Mon Sep 17 00:00:00 2001 From: Stratoula Kalafateli Date: Mon, 8 Nov 2021 18:58:31 +0200 Subject: [PATCH] [Lens] Unskips heatmap test suite & stabilizes the dimensionConfiguration helper (#117811) * [Lens] Unskips heatmap test suite * Check if operation button exists --- x-pack/test/functional/apps/lens/heatmap.ts | 13 +++++++------ x-pack/test/functional/page_objects/lens_page.ts | 6 ++++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/x-pack/test/functional/apps/lens/heatmap.ts b/x-pack/test/functional/apps/lens/heatmap.ts index 5b80e6ad5cf55..3f8456e9d75f6 100644 --- a/x-pack/test/functional/apps/lens/heatmap.ts +++ b/x-pack/test/functional/apps/lens/heatmap.ts @@ -12,10 +12,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const PageObjects = getPageObjects(['visualize', 'lens', 'common', 'header']); const elasticChart = getService('elasticChart'); const testSubjects = getService('testSubjects'); + const retry = getService('retry'); - // FLAKY: https://github.com/elastic/kibana/issues/117404 - // FLAKY: https://github.com/elastic/kibana/issues/113043 - describe.skip('lens heatmap', () => { + describe('lens heatmap', () => { before(async () => { await PageObjects.visualize.navigateToNewVisualization(); await PageObjects.visualize.clickVisType('lens'); @@ -73,9 +72,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('should reflect stop colors change on the chart', async () => { await PageObjects.lens.openDimensionEditor('lnsHeatmap_cellPanel > lns-dimensionTrigger'); await PageObjects.lens.openPalettePanel('lnsHeatmap'); - await testSubjects.setValue('lnsPalettePanel_dynamicColoring_stop_value_0', '10', { - clearWithKeyboard: true, - typeCharByChar: true, + await retry.try(async () => { + await testSubjects.setValue('lnsPalettePanel_dynamicColoring_stop_value_0', '10', { + clearWithKeyboard: true, + typeCharByChar: true, + }); }); await PageObjects.lens.waitForVisualization(); diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts index 266aa4955b6e8..247dc607c0038 100644 --- a/x-pack/test/functional/page_objects/lens_page.ts +++ b/x-pack/test/functional/page_objects/lens_page.ts @@ -129,9 +129,11 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont const operationSelector = opts.isPreviousIncompatible ? `lns-indexPatternDimension-${opts.operation} incompatible` : `lns-indexPatternDimension-${opts.operation}`; - await testSubjects.click(operationSelector); + await retry.try(async () => { + await testSubjects.exists(operationSelector); + await testSubjects.click(operationSelector); + }); } - if (opts.field) { const target = await testSubjects.find('indexPattern-dimension-field'); await comboBox.openOptionsList(target);