From 6ecf83090df2283b93cafa142fb275a80a9d5f49 Mon Sep 17 00:00:00 2001
From: Jean-Louis Leysens <jloleysens@gmail.com>
Date: Wed, 19 Aug 2020 17:05:52 +0200
Subject: [PATCH] address pr feedback

---
 .../manage_processor_form/processors/enrich.tsx           | 6 +++---
 .../components/manage_processor_form/processors/fail.tsx  | 8 ++------
 .../manage_processor_form/processors/html_strip.tsx       | 2 +-
 .../manage_processor_form/processors/inference.tsx        | 4 +++-
 .../components/manage_processor_form/processors/join.tsx  | 2 +-
 5 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx
index 20b0470d8fc6b..e5d04b381586d 100644
--- a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx
+++ b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx
@@ -89,7 +89,7 @@ const fieldsConfig: FieldsConfig = {
       'xpack.ingestPipelines.pipelineEditor.enrichForm.overrideFieldHelpText',
       {
         defaultMessage:
-          'Whether this processor will update fields with pre-existing non-null-valued field. When set to false, such fields will not be overridden.',
+          'Whether this processor will update fields with a pre-existing non-null-valued field. When set to false, such fields will not be overridden.',
       }
     ),
   },
@@ -109,7 +109,7 @@ const fieldsConfig: FieldsConfig = {
       'xpack.ingestPipelines.pipelineEditor.enrichForm.maxMatchesFieldHelpText',
       {
         defaultMessage:
-          'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object',
+          'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object. Accepts numbers are 1 up to 128.',
       }
     ),
     validations: [
@@ -152,7 +152,7 @@ export const Enrich: FunctionComponent = () => {
           'xpack.ingestPipelines.pipelineEditor.enrichForm.fieldNameHelpText',
           {
             defaultMessage:
-              'The field in the input document that matches the policies match_field used to retrieve the enrichment data',
+              'The field in the input document that matches the policy field used to retrieve the enrichment data.',
           }
         )}
       />
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx
index 8d53aaa75e29b..93b7594531c0e 100644
--- a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx
+++ b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx
@@ -21,7 +21,7 @@ const fieldsConfig: FieldsConfig = {
       defaultMessage: 'Message',
     }),
     helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.failForm.messageHelpText', {
-      defaultMessage: 'The error message thrown by the processor',
+      defaultMessage: 'The error message thrown by the processor.',
     }),
     validations: [
       {
@@ -36,9 +36,5 @@ const fieldsConfig: FieldsConfig = {
 };
 
 export const Fail: FunctionComponent = () => {
-  return (
-    <>
-      <UseField component={Field} config={fieldsConfig.message} path="fields.message" />
-    </>
-  );
+  return <UseField component={Field} config={fieldsConfig.message} path="fields.message" />;
 };
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx
index 11999d26b4f2a..8261cfaa3814a 100644
--- a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx
+++ b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx
@@ -26,7 +26,7 @@ export const HtmlStrip: FunctionComponent = () => {
           'xpack.ingestPipelines.pipelineEditor.htmlStripForm.targetFieldHelpText',
           {
             defaultMessage:
-              'The field to assign the stripped value to. If blank the field will be updated in-place.',
+              'The field to assign the stripped value to. If blank, the field will be updated in-place.',
           }
         )}
       />
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx
index 73ef1bffdbe39..8ff75314e2a67 100644
--- a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx
+++ b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx
@@ -50,6 +50,7 @@ const getInferenceConfigHelpText = (esDocsBasePath: string): React.ReactNode =>
       values={{
         regression: (
           <EuiLink
+            external
             target="_blank"
             href={`${esDocsBasePath}/${INFERENCE_CONFIG_DOCS.regression.path}`}
           >
@@ -58,6 +59,7 @@ const getInferenceConfigHelpText = (esDocsBasePath: string): React.ReactNode =>
         ),
         classification: (
           <EuiLink
+            external
             target="_blank"
             href={`${esDocsBasePath}/${INFERENCE_CONFIG_DOCS.classification.path}`}
           >
@@ -164,7 +166,7 @@ export const Inference: FunctionComponent = () => {
         helpText={
           <FormattedMessage
             id="xpack.ingestPipelines.pipelineEditor.inferenceForm.targetFieldHelpText"
-            defaultMessage="Field added to incoming documents to contain results objects. Default value is {targetField}."
+            defaultMessage="Field added to incoming documents that will contain inference processor results. Default value is {targetField}."
             values={{ targetField: <EuiCode inline>{'ml.inference.<processor_tag>'}</EuiCode> }}
           />
         }
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx
index fa17513beacb5..2c88007b54d80 100644
--- a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx
+++ b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx
@@ -26,7 +26,7 @@ const fieldsConfig: FieldsConfig = {
     helpText: i18n.translate(
       'xpack.ingestPipelines.pipelineEditor.joinForm.separatorFieldHelpText',
       {
-        defaultMessage: 'The separator character',
+        defaultMessage: 'The separator character.',
       }
     ),
     validations: [