From 54b5d15aacd2c10f520a846acaf9eef0fd187fb1 Mon Sep 17 00:00:00 2001 From: Alison Goryachev Date: Wed, 11 Mar 2020 15:47:25 -0400 Subject: [PATCH] address review feedback --- .../plugins/painless_lab/server/routes/api/execute.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/painless_lab/server/routes/api/execute.ts b/x-pack/plugins/painless_lab/server/routes/api/execute.ts index 67da80b51e72d..f8bac0392fc12 100644 --- a/x-pack/plugins/painless_lab/server/routes/api/execute.ts +++ b/x-pack/plugins/painless_lab/server/routes/api/execute.ts @@ -37,17 +37,13 @@ export function registerExecuteRoute({ router, license }: RouteDependencies) { body: response, }); } catch (e) { - // Invalid painless script was submitted - // Return 200 with error object - if (e.body) { + if (isEsError(e)) { + // Assume invalid painless script was submitted + // Return 200 with error object return res.ok({ body: e.body, }); } - - if (isEsError(e)) { - return res.customError({ statusCode: e.statusCode, body: e }); - } return res.internalError({ body: e }); } })