test
diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts
index 8609eef92a268..91c3903a279d0 100644
--- a/src/dev/license_checker/config.ts
+++ b/src/dev/license_checker/config.ts
@@ -87,7 +87,7 @@ export const LICENSE_OVERRIDES = {
'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/ems-client@8.5.3': ['Elastic License 2.0'],
- '@elastic/eui@97.3.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
+ '@elastic/eui@97.3.1': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary
'@bufbuild/protobuf@1.2.1': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause)
diff --git a/src/plugins/controls/common/constants.ts b/src/plugins/controls/common/constants.ts
index d1434d4df2ae0..afd6fe66f0df1 100644
--- a/src/plugins/controls/common/constants.ts
+++ b/src/plugins/controls/common/constants.ts
@@ -16,7 +16,7 @@ export const CONTROL_CHAINING_OPTIONS = { NONE: 'NONE', HIERARCHICAL: 'HIERARCHI
export const DEFAULT_CONTROL_WIDTH: ControlWidth = CONTROL_WIDTH_OPTIONS.MEDIUM;
export const DEFAULT_CONTROL_LABEL_POSITION: ControlLabelPosition =
CONTROL_LABEL_POSITION_OPTIONS.ONE_LINE;
-export const DEFAULT_CONTROL_GROW: boolean = true;
+export const DEFAULT_CONTROL_GROW: boolean = false;
export const DEFAULT_CONTROL_CHAINING: ControlGroupChainingSystem =
CONTROL_CHAINING_OPTIONS.HIERARCHICAL;
export const DEFAULT_IGNORE_PARENT_SETTINGS = {
diff --git a/src/plugins/controls/public/control_group/components/control_group_editor.tsx b/src/plugins/controls/public/control_group/components/control_group_editor.tsx
index 8f1ccb4d699b0..cb21c23bc9ce4 100644
--- a/src/plugins/controls/public/control_group/components/control_group_editor.tsx
+++ b/src/plugins/controls/public/control_group/components/control_group_editor.tsx
@@ -72,7 +72,7 @@ export const ControlGroupEditor = ({ onCancel, onSave, onDeleteAll, stateManager
return (
<>
-
+
{ControlGroupStrings.management.getFlyoutTitle()}
@@ -80,7 +80,7 @@ export const ControlGroupEditor = ({ onCancel, onSave, onDeleteAll, stateManager
{
onCancel();
}}
@@ -204,7 +204,7 @@ export const ControlGroupEditor = ({ onCancel, onSave, onDeleteAll, stateManager
{
diff --git a/src/plugins/controls/public/control_group/control_group_strings.tsx b/src/plugins/controls/public/control_group/control_group_strings.tsx
index b8f6a11abf839..f5c92d987b271 100644
--- a/src/plugins/controls/public/control_group/control_group_strings.tsx
+++ b/src/plugins/controls/public/control_group/control_group_strings.tsx
@@ -12,7 +12,7 @@ import { i18n } from '@kbn/i18n';
export const ControlGroupStrings = {
getSaveChangesTitle: () =>
i18n.translate('controls.controlGroup.manageControl.saveChangesTitle', {
- defaultMessage: 'Save and close',
+ defaultMessage: 'Save',
}),
getCancelTitle: () =>
i18n.translate('controls.controlGroup.manageControl.cancelTitle', {
diff --git a/src/plugins/controls/public/control_group/init_controls_manager.test.ts b/src/plugins/controls/public/control_group/init_controls_manager.test.ts
index 29998325664bb..d88dc5452a0e5 100644
--- a/src/plugins/controls/public/control_group/init_controls_manager.test.ts
+++ b/src/plugins/controls/public/control_group/init_controls_manager.test.ts
@@ -263,7 +263,7 @@ describe('getNewControlState', () => {
test('should contain defaults when there are no existing controls', () => {
const controlsManager = initControlsManager({}, new BehaviorSubject({}));
expect(controlsManager.getNewControlState()).toEqual({
- grow: true,
+ grow: false,
width: 'medium',
dataViewId: undefined,
});
@@ -284,7 +284,7 @@ describe('getNewControlState', () => {
new BehaviorSubject(intialControlsState)
);
expect(controlsManager.getNewControlState()).toEqual({
- grow: true,
+ grow: false,
width: 'medium',
dataViewId: 'myOtherDataViewId',
});
diff --git a/src/plugins/controls/public/control_group/open_edit_control_group_flyout.tsx b/src/plugins/controls/public/control_group/open_edit_control_group_flyout.tsx
index 54e35ab271b34..459913d98de0b 100644
--- a/src/plugins/controls/public/control_group/open_edit_control_group_flyout.tsx
+++ b/src/plugins/controls/public/control_group/open_edit_control_group_flyout.tsx
@@ -101,6 +101,9 @@ export const openEditControlGroupFlyout = (
'aria-label': i18n.translate('controls.controlGroup.manageControl', {
defaultMessage: 'Edit control settings',
}),
+ size: 'm',
+ maxWidth: 500,
+ paddingSize: 'm',
outsideClickCloses: false,
onClose: () => closeOverlay(overlay),
}
diff --git a/src/plugins/controls/public/controls/data_controls/data_control_constants.tsx b/src/plugins/controls/public/controls/data_controls/data_control_constants.tsx
index 6b06bd8a52439..23d4c68f6c5dc 100644
--- a/src/plugins/controls/public/controls/data_controls/data_control_constants.tsx
+++ b/src/plugins/controls/public/controls/data_controls/data_control_constants.tsx
@@ -21,14 +21,6 @@ export const DataControlEditorStrings = {
defaultMessage: 'Edit control',
}),
dataSource: {
- getFormGroupTitle: () =>
- i18n.translate('controls.controlGroup.manageControl.dataSource.formGroupTitle', {
- defaultMessage: 'Data source',
- }),
- getFormGroupDescription: () =>
- i18n.translate('controls.controlGroup.manageControl.dataSource.formGroupDescription', {
- defaultMessage: 'Select the data view and field that you want to create a control for.',
- }),
getSelectDataViewMessage: () =>
i18n.translate('controls.controlGroup.manageControl.dataSource.selectDataViewMessage', {
defaultMessage: 'Please select a data view',
@@ -95,14 +87,6 @@ export const DataControlEditorStrings = {
},
},
displaySettings: {
- getFormGroupTitle: () =>
- i18n.translate('controls.controlGroup.manageControl.displaySettings.formGroupTitle', {
- defaultMessage: 'Display settings',
- }),
- getFormGroupDescription: () =>
- i18n.translate('controls.controlGroup.manageControl.displaySettings.formGroupDescription', {
- defaultMessage: 'Change how the control appears on your dashboard.',
- }),
getTitleInputTitle: () =>
i18n.translate('controls.controlGroup.manageControl.displaySettings.titleInputTitle', {
defaultMessage: 'Label',
@@ -133,7 +117,7 @@ export const DataControlEditorStrings = {
},
getSaveChangesTitle: () =>
i18n.translate('controls.controlGroup.manageControl.saveChangesTitle', {
- defaultMessage: 'Save and close',
+ defaultMessage: 'Save',
}),
getCancelTitle: () =>
i18n.translate('controls.controlGroup.manageControl.cancelTitle', {
diff --git a/src/plugins/controls/public/controls/data_controls/data_control_editor.tsx b/src/plugins/controls/public/controls/data_controls/data_control_editor.tsx
index 23fd95978ff82..a84425f350dc1 100644
--- a/src/plugins/controls/public/controls/data_controls/data_control_editor.tsx
+++ b/src/plugins/controls/public/controls/data_controls/data_control_editor.tsx
@@ -15,7 +15,6 @@ import {
EuiButtonEmpty,
EuiButtonGroup,
EuiCallOut,
- EuiDescribedFormGroup,
EuiFieldText,
EuiFlexGroup,
EuiFlexItem,
@@ -250,20 +249,8 @@ export const DataControlEditor =
- {DataControlEditorStrings.manageControl.controlTypeSettings.getFormGroupTitle(
- controlFactory.getDisplayName()
- )}
-
- }
- description={DataControlEditorStrings.manageControl.controlTypeSettings.getFormGroupDescription(
- controlFactory.getDisplayName()
- )}
- data-test-subj="control-editor-custom-settings"
- >
+
+
-
+
);
}, [fieldRegistry, controlFactory, initialState, editorState, controlGroupApi]);
return (
<>
-
+
{!controlId // if no ID, then we are creating a new control
? DataControlEditorStrings.manageControl.getFlyoutCreateTitle()
@@ -288,156 +275,144 @@ export const DataControlEditor =
- {DataControlEditorStrings.manageControl.dataSource.getFormGroupTitle()}
}
- description={DataControlEditorStrings.manageControl.dataSource.getFormGroupDescription()}
- >
- {!editorConfig?.hideDataViewSelector && (
-
- {dataViewListError ? (
-
- {dataViewListError.message}
-
- ) : (
- {
- setEditorState({ ...editorState, dataViewId: newDataViewId });
- setSelectedControlType(undefined);
- }}
- trigger={{
- label:
- selectedDataView?.getName() ??
- DataControlEditorStrings.manageControl.dataSource.getSelectDataViewMessage(),
- }}
- selectableProps={{ isLoading: dataViewListLoading }}
- />
- )}
-
- )}
-
-
- {fieldListError ? (
+ {!editorConfig?.hideDataViewSelector && (
+
+ {dataViewListError ? (
- {fieldListError.message}
+ {dataViewListError.message}
) : (
- {
- const customPredicate = editorConfig?.fieldFilterPredicate?.(field) ?? true;
- return Boolean(fieldRegistry?.[field.name]) && customPredicate;
+ {
+ setEditorState({ ...editorState, dataViewId: newDataViewId });
+ setSelectedControlType(undefined);
}}
- selectedFieldName={editorState.fieldName}
- dataView={selectedDataView}
- onSelectField={(field) => {
- setEditorState({ ...editorState, fieldName: field.name });
-
- /**
- * make sure that the new field is compatible with the selected control type and, if it's not,
- * reset the selected control type to the **first** compatible control type
- */
- const newCompatibleControlTypes =
- fieldRegistry?.[field.name]?.compatibleControlTypes ?? [];
- if (
- !selectedControlType ||
- !newCompatibleControlTypes.includes(selectedControlType!)
- ) {
- setSelectedControlType(newCompatibleControlTypes[0]);
- }
-
- /**
- * set the control title (i.e. the one set by the user) + default title (i.e. the field display name)
- */
- const newDefaultTitle = field.displayName ?? field.name;
- setDefaultPanelTitle(newDefaultTitle);
- const currentTitle = editorState.title;
- if (!currentTitle || currentTitle === newDefaultTitle) {
- setPanelTitle(newDefaultTitle);
- }
-
- setControlOptionsValid(true); // reset options state
+ trigger={{
+ label:
+ selectedDataView?.getName() ??
+ DataControlEditorStrings.manageControl.dataSource.getSelectDataViewMessage(),
}}
- selectableProps={{ isLoading: dataViewListLoading || dataViewLoading }}
+ selectableProps={{ isLoading: dataViewListLoading }}
/>
)}
+ )}
+
+
+ {fieldListError ? (
+
+ {fieldListError.message}
+
+ ) : (
+ {
+ const customPredicate = editorConfig?.fieldFilterPredicate?.(field) ?? true;
+ return Boolean(fieldRegistry?.[field.name]) && customPredicate;
+ }}
+ selectedFieldName={editorState.fieldName}
+ dataView={selectedDataView}
+ onSelectField={(field) => {
+ setEditorState({ ...editorState, fieldName: field.name });
+
+ /**
+ * make sure that the new field is compatible with the selected control type and, if it's not,
+ * reset the selected control type to the **first** compatible control type
+ */
+ const newCompatibleControlTypes =
+ fieldRegistry?.[field.name]?.compatibleControlTypes ?? [];
+ if (
+ !selectedControlType ||
+ !newCompatibleControlTypes.includes(selectedControlType!)
+ ) {
+ setSelectedControlType(newCompatibleControlTypes[0]);
+ }
+
+ /**
+ * set the control title (i.e. the one set by the user) + default title (i.e. the field display name)
+ */
+ const newDefaultTitle = field.displayName ?? field.name;
+ setDefaultPanelTitle(newDefaultTitle);
+ const currentTitle = editorState.title;
+ if (!currentTitle || currentTitle === newDefaultTitle) {
+ setPanelTitle(newDefaultTitle);
+ }
+
+ setControlOptionsValid(true); // reset options state
+ }}
+ selectableProps={{ isLoading: dataViewListLoading || dataViewLoading }}
+ />
+ )}
+
+
+ {/* wrapping in `div` so that focus gets passed properly to the form row */}
+
+
+
+
+
+ {
+ setPanelTitle(e.target.value ?? '');
+ setEditorState({
+ ...editorState,
+ title: e.target.value === '' ? undefined : e.target.value,
+ });
+ }}
+ />
+
+ {!editorConfig?.hideWidthSettings && (
- {/* wrapping in `div` so that focus gets passed properly to the form row */}
-
+ setEditorState({ ...editorState, width: newWidth as ControlWidth })
+ }
+ />
+
+ setEditorState({ ...editorState, grow: !editorState.grow })}
+ data-test-subj="control-editor-grow-switch"
/>
-
- {DataControlEditorStrings.manageControl.displaySettings.getFormGroupTitle()}
- }
- description={DataControlEditorStrings.manageControl.displaySettings.getFormGroupDescription()}
- >
-
- {
- setPanelTitle(e.target.value ?? '');
- setEditorState({
- ...editorState,
- title: e.target.value === '' ? undefined : e.target.value,
- });
- }}
- />
-
- {!editorConfig?.hideWidthSettings && (
-
-
-
- setEditorState({ ...editorState, width: newWidth as ControlWidth })
- }
- />
-
- setEditorState({ ...editorState, grow: !editorState.grow })}
- data-test-subj="control-editor-grow-switch"
- />
-
-
- )}
-
+ )}
{!editorConfig?.hideAdditionalSettings && CustomSettingsComponent}
{controlId && (
<>
@@ -464,7 +439,6 @@ export const DataControlEditor = {
onCancel(editorState);
}}
@@ -476,7 +450,7 @@ export const DataControlEditor = closeOverlay(overlay),
}
);
diff --git a/src/plugins/controls/public/controls/data_controls/options_list_control/components/options_list_editor_options.tsx b/src/plugins/controls/public/controls/data_controls/options_list_control/components/options_list_editor_options.tsx
index e9dad12be5623..f07a7cc6c58bf 100644
--- a/src/plugins/controls/public/controls/data_controls/options_list_control/components/options_list_editor_options.tsx
+++ b/src/plugins/controls/public/controls/data_controls/options_list_control/components/options_list_editor_options.tsx
@@ -131,6 +131,7 @@ export const OptionsListEditorOptions = ({
data-test-subj="optionsListControl__selectionOptionsRadioGroup"
>
{
@@ -146,6 +147,7 @@ export const OptionsListEditorOptions = ({
data-test-subj="optionsListControl__searchOptionsRadioGroup"
>
{
@@ -158,6 +160,7 @@ export const OptionsListEditorOptions = ({
)}
{
const newStep = event.target.valueAsNumber;
diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/add_new_panel/dashboard_panel_selection_flyout.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/add_new_panel/dashboard_panel_selection_flyout.tsx
index dbb86046def06..e6adece8ab36d 100644
--- a/src/plugins/dashboard/public/dashboard_app/top_nav/add_new_panel/dashboard_panel_selection_flyout.tsx
+++ b/src/plugins/dashboard/public/dashboard_app/top_nav/add_new_panel/dashboard_panel_selection_flyout.tsx
@@ -125,7 +125,7 @@ export const DashboardPanelSelectionListFlyout: React.FC<
return (
<>
-
+
{
@@ -281,7 +282,7 @@ export const DashboardPanelSelectionListFlyout: React.FC<
diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx
index 2cad63c442026..cf7f9c65c6618 100644
--- a/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx
+++ b/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx
@@ -43,7 +43,7 @@ export const EditorMenu = ({ createNewVisType, isDisabled }: EditorMenuProps) =>
function openDashboardPanelSelectionFlyout() {
const flyoutPanelPaddingSize: ComponentProps<
typeof DashboardPanelSelectionListFlyout
- >['paddingSize'] = 'l';
+ >['paddingSize'] = 'm';
const mount = toMountPoint(
React.createElement(function () {
diff --git a/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx b/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx
index 20ab07e1155cd..26f0563215536 100644
--- a/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx
+++ b/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx
@@ -8,8 +8,8 @@
*/
import React, { useCallback, useEffect, useMemo, useRef } from 'react';
-import { type DataView, DataViewType } from '@kbn/data-views-plugin/public';
-import { DataViewPickerProps } from '@kbn/unified-search-plugin/public';
+import { DataViewType } from '@kbn/data-views-plugin/public';
+import type { DataViewPickerProps } from '@kbn/unified-search-plugin/public';
import { ENABLE_ESQL } from '@kbn/esql-utils';
import { TextBasedLanguages } from '@kbn/esql-utils';
import { DiscoverFlyouts, dismissAllFlyoutsExceptFor } from '@kbn/discover-utils';
@@ -20,7 +20,6 @@ import { useDiscoverServices } from '../../../../hooks/use_discover_services';
import type { DiscoverStateContainer } from '../../state_management/discover_state';
import { onSaveSearch } from './on_save_search';
import { useDiscoverCustomization } from '../../../../customizations';
-import { addLog } from '../../../../utils/add_log';
import { useAppStateSelector } from '../../state_management/discover_app_state_container';
import { useDiscoverTopNav } from './use_discover_topnav';
import { useIsEsqlMode } from '../../hooks/use_is_esql_mode';
@@ -47,15 +46,8 @@ export const DiscoverTopNav = ({
onCancelClick,
}: DiscoverTopNavProps) => {
const services = useDiscoverServices();
- const {
- dataViewEditor,
- navigation,
- dataViewFieldEditor,
- data,
- uiSettings,
- dataViews,
- setHeaderActionMenu,
- } = services;
+ const { dataViewEditor, navigation, dataViewFieldEditor, data, uiSettings, setHeaderActionMenu } =
+ services;
const query = useAppStateSelector((state) => state.query);
const adHocDataViews = useInternalStateSelector((state) => state.adHocDataViews);
const dataView = useInternalStateSelector((state) => state.dataView!);
@@ -93,7 +85,7 @@ export const DiscoverTopNav = ({
const editField = useMemo(
() =>
canEditDataView
- ? async (fieldName?: string, uiAction: 'edit' | 'add' = 'edit') => {
+ ? async (fieldName?: string) => {
if (dataView?.id) {
const dataViewInstance = await data.dataViews.get(dataView.id);
closeFieldEditor.current = await dataViewFieldEditor.openEditor({
@@ -112,7 +104,7 @@ export const DiscoverTopNav = ({
);
const addField = useMemo(
- () => (canEditDataView && editField ? () => editField(undefined, 'add') : undefined),
+ () => (canEditDataView && editField ? () => editField() : undefined),
[editField, canEditDataView]
);
@@ -123,23 +115,6 @@ export const DiscoverTopNav = ({
});
}, [dataViewEditor, stateContainer]);
- const onEditDataView = useCallback(
- async (editedDataView: DataView) => {
- if (editedDataView.isPersisted()) {
- // Clear the current data view from the cache and create a new instance
- // of it, ensuring we have a new object reference to trigger a re-render
- dataViews.clearInstanceCache(editedDataView.id);
- stateContainer.actions.setDataView(await dataViews.create(editedDataView.toSpec(), true));
- } else {
- await stateContainer.actions.updateAdHocDataViewId();
- }
- stateContainer.actions.loadDataViewList();
- addLog('[DiscoverTopNav] onEditDataView triggers data fetching');
- stateContainer.dataState.fetch();
- },
- [dataViews, stateContainer.actions, stateContainer.dataState]
- );
-
const updateSavedQueryId = (newSavedQueryId: string | undefined) => {
const { appState } = stateContainer;
if (newSavedQueryId) {
@@ -223,14 +198,13 @@ export const DiscoverTopNav = ({
textBasedLanguages: supportedTextBasedLanguages,
adHocDataViews,
savedDataViews,
- onEditDataView,
+ onEditDataView: stateContainer.actions.onDataViewEdited,
};
}, [
adHocDataViews,
addField,
createNewDataView,
dataView,
- onEditDataView,
savedDataViews,
stateContainer,
uiSettings,
diff --git a/src/plugins/embeddable/public/add_panel_flyout/add_panel_flyout.tsx b/src/plugins/embeddable/public/add_panel_flyout/add_panel_flyout.tsx
index b83ebbcb49d66..b334dbcb5857a 100644
--- a/src/plugins/embeddable/public/add_panel_flyout/add_panel_flyout.tsx
+++ b/src/plugins/embeddable/public/add_panel_flyout/add_panel_flyout.tsx
@@ -189,7 +189,7 @@ export const AddPanelFlyout = ({
return (
<>
-
+
{i18n.translate('embeddableApi.addPanel.Title', { defaultMessage: 'Add from library' })}
diff --git a/src/plugins/embeddable/public/add_panel_flyout/open_add_panel_flyout.tsx b/src/plugins/embeddable/public/add_panel_flyout/open_add_panel_flyout.tsx
index 160289d0d1c2a..9ba3c00a73745 100644
--- a/src/plugins/embeddable/public/add_panel_flyout/open_add_panel_flyout.tsx
+++ b/src/plugins/embeddable/public/add_panel_flyout/open_add_panel_flyout.tsx
@@ -52,6 +52,9 @@ export const openAddPanelFlyout = ({
if (onClose) onClose();
overlayRef.close();
},
+ size: 'm',
+ maxWidth: 500,
+ paddingSize: 'm',
'data-test-subj': 'dashboardAddPanel',
'aria-labelledby': modalTitleId,
}
diff --git a/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.test.tsx b/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.test.tsx
index 265f162d04f6c..f052f0526a945 100644
--- a/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.test.tsx
+++ b/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.test.tsx
@@ -43,11 +43,11 @@ const ImageEditor = (props: Partial) => {
);
};
-test('should call onCancel when "Close" clicked', async () => {
+test('should call onCancel when "Cancel" clicked', async () => {
const onCancel = jest.fn();
const { getByText } = render();
- expect(getByText('Close')).toBeVisible();
- await userEvent.click(getByText('Close'));
+ expect(getByText('Cancel')).toBeVisible();
+ await userEvent.click(getByText('Cancel'));
expect(onCancel).toBeCalled();
});
diff --git a/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.tsx b/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.tsx
index 2c57f25db6c8b..1a5ee3bc64e1d 100644
--- a/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.tsx
+++ b/src/plugins/image_embeddable/public/components/image_editor/image_editor_flyout.tsx
@@ -121,7 +121,7 @@ export function ImageEditorFlyout(props: ImageEditorFlyoutProps) {
return (
<>
-
+
{isEditing ? (
-
-
+
+
+
setSrcType('file')} isSelected={srcType === 'file'}>
-
-
+
{srcType === 'file' && (
<>
{isDraftImageConfigValid ? (
@@ -238,7 +238,7 @@ export function ImageEditorFlyout(props: ImageEditorFlyoutProps) {
/>
}
- titleSize={'s'}
+ titleSize={'xs'}
/>
) : (
)}
-
-
+
)}
-
-
-
-
-
-
+
diff --git a/src/plugins/image_embeddable/public/components/image_editor/open_image_editor.tsx b/src/plugins/image_embeddable/public/components/image_editor/open_image_editor.tsx
index ae8ced88d14ef..f730147cb0d2c 100644
--- a/src/plugins/image_embeddable/public/components/image_editor/open_image_editor.tsx
+++ b/src/plugins/image_embeddable/public/components/image_editor/open_image_editor.tsx
@@ -79,6 +79,9 @@ export const openImageEditor = async ({
onClose: () => {
onCancel();
},
+ size: 'm',
+ maxWidth: 500,
+ paddingSize: 'm',
ownFocus: true,
'data-test-subj': 'createImageEmbeddableFlyout',
}
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
index 779150faa89fb..e3374219b6553 100644
--- a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
+++ b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -578,10 +578,6 @@ export const stackManagementSchema: MakeSchemaFrom = {
type: 'boolean',
_meta: { description: 'Non-default value of setting.' },
},
- 'metrics:allowCheckingForFailedShards': {
- type: 'boolean',
- _meta: { description: 'Non-default value of setting.' },
- },
'observability:apmDefaultServiceEnvironment': {
type: 'keyword',
_meta: { description: 'Default value of the setting was changed.' },
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
index 2734ab6304319..b49647c3d4791 100644
--- a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
+++ b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -152,7 +152,6 @@ export interface UsageStats {
'discover:rowHeightOption': number;
hideAnnouncements: boolean;
isDefaultIndexMigrated: boolean;
- 'metrics:allowCheckingForFailedShards': boolean;
'observability:syntheticsThrottlingEnabled': boolean;
'observability:enableLegacyUptimeApp': boolean;
'observability:apmLabsButton': boolean;
diff --git a/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx b/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx
index b062b9befa284..ab5b923327049 100644
--- a/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx
+++ b/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx
@@ -119,6 +119,7 @@ export const DashboardLinkDestinationPicker = ({
return (
onClose()}
>
-
+
{link
? LinksStrings.editor.getEditLinkTitle()
@@ -113,6 +113,7 @@ export const LinkEditor = ({
{
@@ -131,6 +132,7 @@ export const LinkEditor = ({
/>
onClose()}
- iconType="cross"
data-test-subj="links--linkEditor--closeBtn"
>
{LinksStrings.editor.getCancelButtonLabel()}
@@ -160,6 +162,7 @@ export const LinkEditor = ({
{
// this check should always be true, since the button is disabled otherwise - this is just for type safety
diff --git a/src/plugins/links/public/components/editor/links_editor.scss b/src/plugins/links/public/components/editor/links_editor.scss
index 02961c7d5f5cb..c33b95350df98 100644
--- a/src/plugins/links/public/components/editor/links_editor.scss
+++ b/src/plugins/links/public/components/editor/links_editor.scss
@@ -3,7 +3,7 @@
.linksPanelEditor {
.linkEditor {
@include euiFlyout;
- max-inline-size: $euiSizeXXL * 18; // 40px * 18 = 720px
+ max-inline-size: $euiSizeXS * 125; // 4px * 125 = 500px
&.in {
animation: euiFlyoutOpenAnimation $euiAnimSpeedNormal $euiAnimSlightResistance;
@@ -59,6 +59,9 @@
}
.links_hoverActions {
+ background-color: $euiColorEmptyShade;
+ position: absolute;
+ right: $euiSizeL;
opacity: 0;
visibility: hidden;
transition: visibility $euiAnimSpeedNormal, opacity $euiAnimSpeedNormal;
diff --git a/src/plugins/links/public/components/editor/links_editor.tsx b/src/plugins/links/public/components/editor/links_editor.tsx
index 93ca47e364c57..8fa33fd4ebcaa 100644
--- a/src/plugins/links/public/components/editor/links_editor.tsx
+++ b/src/plugins/links/public/components/editor/links_editor.tsx
@@ -167,7 +167,7 @@ const LinksEditor = ({
-
+
{isEditingExisting
? LinksStrings.editor.panelEditor.getEditFlyoutTitle()
@@ -251,7 +251,6 @@ const LinksEditor = ({
@@ -268,6 +267,7 @@ const LinksEditor = ({
data-test-subj="links--panelEditor--saveByReferenceTooltip"
>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
);
diff --git a/src/plugins/links/public/components/external_link/external_link_destination_picker.tsx b/src/plugins/links/public/components/external_link/external_link_destination_picker.tsx
index dfdc6e0589e6b..5b8522b39960e 100644
--- a/src/plugins/links/public/components/external_link/external_link_destination_picker.tsx
+++ b/src/plugins/links/public/components/external_link/external_link_destination_picker.tsx
@@ -54,6 +54,7 @@ export const ExternalLinkDestinationPicker = ({
return (
i18n.translate('links.editor.cancelButtonLabel', {
- defaultMessage: 'Close',
+ defaultMessage: 'Cancel',
}),
panelEditor: {
getLinksTitle: () =>
diff --git a/src/plugins/links/public/editor/open_editor_flyout.tsx b/src/plugins/links/public/editor/open_editor_flyout.tsx
index 041672e89dbbe..87b1ab4e21ff8 100644
--- a/src/plugins/links/public/editor/open_editor_flyout.tsx
+++ b/src/plugins/links/public/editor/open_editor_flyout.tsx
@@ -137,7 +137,8 @@ export async function openEditorFlyout({
),
{
id: flyoutId,
- maxWidth: 720,
+ maxWidth: 500,
+ paddingSize: 'm',
ownFocus: true,
onClose: onCancel,
outsideClickCloses: false,
diff --git a/src/plugins/presentation_util/public/components/dashboard_drilldown_options/dashboard_drilldown_options.tsx b/src/plugins/presentation_util/public/components/dashboard_drilldown_options/dashboard_drilldown_options.tsx
index 921560f7a2224..63ff89da2ec17 100644
--- a/src/plugins/presentation_util/public/components/dashboard_drilldown_options/dashboard_drilldown_options.tsx
+++ b/src/plugins/presentation_util/public/components/dashboard_drilldown_options/dashboard_drilldown_options.tsx
@@ -8,7 +8,7 @@
*/
import React from 'react';
-import { EuiFormRow, EuiSwitch } from '@elastic/eui';
+import { EuiFormRow, EuiSpacer, EuiSwitch } from '@elastic/eui';
import { DashboardDrilldownOptions } from './types';
import { dashboardDrilldownConfigStrings } from '../../i18n/dashboard_drilldown_config';
@@ -24,32 +24,35 @@ export const DashboardDrilldownOptionsComponent = ({
}: DashboardDrilldownOptionsProps) => {
return (
<>
-
- onOptionChange({ useCurrentFilters: !options.useCurrentFilters })}
- data-test-subj="dashboardDrillDownOptions--useCurrentFilters--checkbox"
- />
-
-
- onOptionChange({ useCurrentDateRange: !options.useCurrentDateRange })}
- data-test-subj="dashboardDrillDownOptions--useCurrentDateRange--checkbox"
- />
-
-
- onOptionChange({ openInNewTab: !options.openInNewTab })}
- data-test-subj="dashboardDrillDownOptions--openInNewTab--checkbox"
- />
+
+
+ onOptionChange({ useCurrentFilters: !options.useCurrentFilters })}
+ data-test-subj="dashboardDrillDownOptions--useCurrentFilters--checkbox"
+ />
+
+ onOptionChange({ useCurrentDateRange: !options.useCurrentDateRange })}
+ data-test-subj="dashboardDrillDownOptions--useCurrentDateRange--checkbox"
+ />
+
+ onOptionChange({ openInNewTab: !options.openInNewTab })}
+ data-test-subj="dashboardDrillDownOptions--openInNewTab--checkbox"
+ />
+
);
diff --git a/src/plugins/presentation_util/public/components/data_view_picker/data_view_picker.tsx b/src/plugins/presentation_util/public/components/data_view_picker/data_view_picker.tsx
index e985e9bec357a..1c8466097bd98 100644
--- a/src/plugins/presentation_util/public/components/data_view_picker/data_view_picker.tsx
+++ b/src/plugins/presentation_util/public/components/data_view_picker/data_view_picker.tsx
@@ -52,6 +52,7 @@ export function DataViewPicker({
data-test-subj="open-data-view-picker"
onClick={() => setPopoverIsOpen(!isPopoverOpen)}
label={label}
+ size="s"
fullWidth
{...colorProp}
{...rest}
diff --git a/src/plugins/presentation_util/public/components/field_picker/field_picker.tsx b/src/plugins/presentation_util/public/components/field_picker/field_picker.tsx
index daac202f21b66..0b81cfd66156d 100644
--- a/src/plugins/presentation_util/public/components/field_picker/field_picker.tsx
+++ b/src/plugins/presentation_util/public/components/field_picker/field_picker.tsx
@@ -140,6 +140,7 @@ export const FieldPicker = ({
placeholder: i18n.translate('presentationUtil.fieldSearch.searchPlaceHolder', {
defaultMessage: 'Search field names',
}),
+ compressed: true,
disabled: Boolean(selectableProps?.isLoading),
inputRef: setSearchRef,
}}
diff --git a/src/plugins/presentation_util/public/components/field_picker/field_type_filter.tsx b/src/plugins/presentation_util/public/components/field_picker/field_type_filter.tsx
index d2e929b8a9a84..4212668599a0d 100644
--- a/src/plugins/presentation_util/public/components/field_picker/field_type_filter.tsx
+++ b/src/plugins/presentation_util/public/components/field_picker/field_type_filter.tsx
@@ -63,7 +63,7 @@ export function FieldTypeFilter({
);
return (
-
+