From 3d735736b2a277c2361182bbe2f89474942718b9 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Fri, 23 Jun 2023 19:25:58 -0400
Subject: [PATCH] [8.9] [Security Solution] adds missing dependency
 `fieldFormats` in kibana.jsonc (#160445) (#160464)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] adds missing dependency `fieldFormats` in
kibana.jsonc (#160445)](https://github.com/elastic/kibana/pull/160445)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2023-06-23T21:14:17Z","message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com/elastic/kibana/pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v8.9.0","v8.10.0"],"number":160445,"url":"https://github.com/elastic/kibana/pull/160445","mergeCommit":{"message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com/elastic/kibana/pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160445","number":160445,"mergeCommit":{"message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com/elastic/kibana/pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a"}}]}]
BACKPORT-->

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
---
 x-pack/plugins/security_solution/kibana.jsonc    | 12 ++++--------
 x-pack/plugins/security_solution/public/types.ts |  9 +++++++++
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/x-pack/plugins/security_solution/kibana.jsonc b/x-pack/plugins/security_solution/kibana.jsonc
index f24dffb58edc6..245e0b32b5dc7 100644
--- a/x-pack/plugins/security_solution/kibana.jsonc
+++ b/x-pack/plugins/security_solution/kibana.jsonc
@@ -6,10 +6,7 @@
     "id": "securitySolution",
     "server": true,
     "browser": true,
-    "configPath": [
-      "xpack",
-      "securitySolution"
-    ],
+    "configPath": ["xpack", "securitySolution"],
     "requiredPlugins": [
       "actions",
       "alerting",
@@ -24,6 +21,7 @@
       "embeddable",
       "eventLog",
       "features",
+      "fieldFormats",
       "guidedOnboarding",
       "inspector",
       "kubernetesSecurity",
@@ -43,7 +41,7 @@
       "controls",
       "dataViews",
       "savedObjectsManagement",
-      "stackConnectors",
+      "stackConnectors"
     ],
     "optionalPlugins": [
       "cloudExperiments",
@@ -71,8 +69,6 @@
       "unifiedSearch",
       "cloudChat"
     ],
-    "extraPublicDirs": [
-      "common"
-    ]
+    "extraPublicDirs": ["common"]
   }
 }
diff --git a/x-pack/plugins/security_solution/public/types.ts b/x-pack/plugins/security_solution/public/types.ts
index a6ed51a76e82b..2687c1fcab25e 100644
--- a/x-pack/plugins/security_solution/public/types.ts
+++ b/x-pack/plugins/security_solution/public/types.ts
@@ -81,6 +81,15 @@ export interface SetupPlugins {
   ml?: MlPluginSetup;
 }
 
+/**
+ * IMPORTANT - PLEASE READ: When adding new plugins to the
+ * security solution, please ensure you add that plugin
+ * name to the kibana.jsonc file located in ../kibana.jsonc
+ *
+ * Without adding the plugin name there, the plugin will not
+ * fulfill at runtime, despite the types showing up correctly
+ * in the code.
+ */
 export interface StartPlugins {
   cases: CasesUiStart;
   data: DataPublicPluginStart;