From 253f13cead08cf7c14172385f380e4062ba52944 Mon Sep 17 00:00:00 2001
From: Mike Cote <mikecote@users.noreply.github.com>
Date: Tue, 17 Mar 2020 21:49:49 -0400
Subject: [PATCH] Make slack param validation handle empty messages

---
 .../actions/server/builtin_action_types/slack.ts   |  2 +-
 .../tests/actions/builtin_action_types/slack.ts    | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/x-pack/plugins/actions/server/builtin_action_types/slack.ts b/x-pack/plugins/actions/server/builtin_action_types/slack.ts
index 042853796695d..3a351853c1e46 100644
--- a/x-pack/plugins/actions/server/builtin_action_types/slack.ts
+++ b/x-pack/plugins/actions/server/builtin_action_types/slack.ts
@@ -35,7 +35,7 @@ const SecretsSchema = schema.object(secretsSchemaProps);
 export type ActionParamsType = TypeOf<typeof ParamsSchema>;
 
 const ParamsSchema = schema.object({
-  message: schema.string(),
+  message: schema.string({ minLength: 1 }),
 });
 
 // action type definition
diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts
index 5dcff8712a28d..8afa43bfea21e 100644
--- a/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts
+++ b/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts
@@ -159,6 +159,20 @@ export default function slackTest({ getService }: FtrProviderContext) {
       expect(result.status).to.eql('ok');
     });
 
+    it('should handle an empty message error', async () => {
+      const { body: result } = await supertest
+        .post(`/api/action/${simulatedActionId}/_execute`)
+        .set('kbn-xsrf', 'foo')
+        .send({
+          params: {
+            message: '',
+          },
+        })
+        .expect(200);
+      expect(result.status).to.eql('error');
+      expect(result.message).to.match(/error validating action params: \[message\]: /);
+    });
+
     it('should handle a 40x slack error', async () => {
       const { body: result } = await supertest
         .post(`/api/action/${simulatedActionId}/_execute`)