From 13a7b626a7867bf915e660da33e257788d2a8fe3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Louv-Jansen?= Date: Thu, 21 Nov 2024 13:57:11 +0100 Subject: [PATCH] Fix lint issues --- .../server/plugin.ts | 18 ++++++++++++------ .../setup_conversation_and_kb_index_assets.ts | 1 - ...ster_migrate_knowledge_base_entries_task.ts | 2 +- .../tests/complete/functions/summarize.spec.ts | 1 - .../knowledge_base/knowledge_base.spec.ts | 1 - .../knowledge_base_migration.spec.ts | 1 - 6 files changed, 13 insertions(+), 11 deletions(-) diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts b/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts index be1a18f417730..ab40ccc1dd6f1 100644 --- a/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts +++ b/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts @@ -120,13 +120,19 @@ export class ObservabilityAIAssistantPlugin config: this.config, })); - setupConversationAndKbIndexAssets({ core, logger: this.logger }).then(() => { - return registerMigrateKnowledgeBaseEntriesTask({ - core, - taskManager: plugins.taskManager, - logger: this.logger, + setupConversationAndKbIndexAssets({ core, logger: this.logger }) + .then(() => { + return registerMigrateKnowledgeBaseEntriesTask({ + core, + taskManager: plugins.taskManager, + logger: this.logger, + }); + }) + .catch((e) => { + this.logger.error( + `Observability Assistant assets were not setup successfully: ${e.message}` + ); }); - }); service.register(registerFunctions); diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts b/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts index b8f7930dcd664..30d55400bbbda 100644 --- a/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts +++ b/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts @@ -104,6 +104,5 @@ export async function setupConversationAndKbIndexAssets({ } catch (error) { logger.error(`Failed setting up index assets: ${error.message}`); logger.debug(error); - throw error; } } diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts b/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts index 91b9c979206f4..c6bf9c1155693 100644 --- a/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts +++ b/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts @@ -134,7 +134,7 @@ export async function runSemanticTextKnowledgeBaseMigration({ logger.debug(`Knowledge base migration: Migrated ${promises.length} entries`); await runSemanticTextKnowledgeBaseMigration({ esClient, logger }); } catch (e) { - logger.error('Knowledge base migration: Failed to migrate entries'); + logger.error(`Knowledge base migration failed: ${e.message}`); logger.error(e); } } diff --git a/x-pack/test/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts b/x-pack/test/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts index f78ffc3b3b954..b2834cc1e997f 100644 --- a/x-pack/test/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts +++ b/x-pack/test/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts @@ -19,7 +19,6 @@ import { clearKnowledgeBase } from '../../knowledge_base/helpers'; export default function ApiTest({ getService }: FtrProviderContext) { const supertest = getService('supertest'); const log = getService('log'); - const ml = getService('ml'); const es = getService('es'); const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient'); diff --git a/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts b/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts index 058022fee8f51..e179455caa1ce 100644 --- a/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts +++ b/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts @@ -11,7 +11,6 @@ import { FtrProviderContext } from '../../common/ftr_provider_context'; import { clearKnowledgeBase } from './helpers'; export default function ApiTest({ getService }: FtrProviderContext) { - const ml = getService('ml'); const es = getService('es'); const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient'); diff --git a/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts b/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts index 881543d85b968..9667d783b039d 100644 --- a/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts +++ b/x-pack/test/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts @@ -17,7 +17,6 @@ export default function ApiTest({ getService }: FtrProviderContext) { const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient'); const esArchiver = getService('esArchiver'); const es = getService('es'); - const ml = getService('ml'); const archive = 'x-pack/test/functional/es_archives/observability/ai_assistant/knowledge_base_8_15';