From 044597788801d3a935814cb53e3fd2b5a389bbb5 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Thu, 24 Jun 2021 18:40:09 -0400
Subject: [PATCH] Fix Engine Overview not properly stretching to full page
 height (#103337) (#103359)

- Caused by the wrapping <div> around the child views - removing that div and moving the `data-test-subj` hooks to the individual views fixes the issue

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
---
 .../components/engine_overview/engine_overview.test.tsx     | 5 -----
 .../components/engine_overview/engine_overview.tsx          | 6 +-----
 .../components/engine_overview/engine_overview_empty.tsx    | 1 +
 .../components/engine_overview/engine_overview_metrics.tsx  | 1 +
 4 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.test.tsx
index a2e0ba4fcd44d..01472987e4d48 100644
--- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.test.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.test.tsx
@@ -29,11 +29,6 @@ describe('EngineOverview', () => {
     setMockValues(values);
   });
 
-  it('renders', () => {
-    const wrapper = shallow(<EngineOverview />);
-    expect(wrapper.find('[data-test-subj="EngineOverview"]')).toHaveLength(1);
-  });
-
   describe('EmptyEngineOverview', () => {
     it('renders when the engine has no documents & the user can add documents', () => {
       const myRole = { canManageEngineDocuments: true, canViewEngineCredentials: true };
diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx
index a3f98d8c13e8e..e966709dc1084 100644
--- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx
@@ -25,9 +25,5 @@ export const EngineOverview: React.FC = () => {
   const canAddDocuments = canManageEngineDocuments && canViewEngineCredentials;
   const showEngineOverview = !isEngineEmpty || !canAddDocuments || isMetaEngine;
 
-  return (
-    <div data-test-subj="EngineOverview">
-      {showEngineOverview ? <EngineOverviewMetrics /> : <EmptyEngineOverview />}
-    </div>
-  );
+  return showEngineOverview ? <EngineOverviewMetrics /> : <EmptyEngineOverview />;
 };
diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx
index 27d9c3723f126..6f8332e1e332e 100644
--- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx
@@ -34,6 +34,7 @@ export const EmptyEngineOverview: React.FC = () => {
           </EuiButton>,
         ],
       }}
+      data-test-subj="EngineOverview"
     >
       <DocumentCreationButtons />
       <DocumentCreationFlyout />
diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx
index 3cc7138623735..9c3a900dfe115 100644
--- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx
@@ -36,6 +36,7 @@ export const EngineOverviewMetrics: React.FC = () => {
         }),
       }}
       isLoading={dataLoading}
+      data-test-subj="EngineOverview"
     >
       <EuiFlexGroup>
         <EuiFlexItem grow={1}>