Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse description lists #882

Merged
merged 4 commits into from
May 29, 2018
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented May 25, 2018

The default of normal will display as is now. The new option, reverse, will reverse the style of the title and description to emphasize the description.

I purposefully did not alter the inline description list to use this reverse style as it didn't make sense the way that one is laid out. It seems counter to what that style accomplishes.

I also added a .eui-definitionListReverse class for dls in EuiText.

screen shot 2018-05-25 at 18 09 31 pm

@cchaos cchaos requested a review from snide May 25, 2018 22:32
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snide
Copy link
Contributor

snide commented May 29, 2018

jenkins, test this

@cchaos cchaos merged commit 8f6bb4e into elastic:master May 29, 2018
@cchaos cchaos deleted the reverse-description-lists branch May 29, 2018 18:39
snide pushed a commit to snide/eui that referenced this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants