-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiStepsHorizontal] Create size prop to generate smaller step circles for horizontal steps
#6928
Merged
breehall
merged 8 commits into
elastic:main
from
breehall:feature/horizontal-step-small
Jul 11, 2023
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
487d170
[EuiStepsHorizontal] Add size prop that generates a smaller step circ…
breehall 41d5dc1
[EuiStepsHorizontal] Add documentation for new size prop
breehall 0d83217
[EuiStepsHorizontal] Update snapshot test and add new test for size prop
breehall 7578774
Changelog
breehall 6346230
Whoops! Wrong changelog number
breehall 785011e
Update src/components/steps/step_horizontal.styles.ts
breehall e29cebd
[PR Feedback] Make the internal step size and inset generation flexible.
breehall 4e04c59
Update upcoming_changelogs/6928.md
breehall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,67 @@ | ||
| import React from 'react'; | ||
| import React, { useState } from 'react'; | ||
|
|
||
| import { | ||
| EuiStepsHorizontal, | ||
| EuiStepsHorizontalProps, | ||
| EuiStepsHorizontalSizes, | ||
| EuiButtonGroup, | ||
| EuiTitle, | ||
| EuiSpacer, | ||
| } from '../../../../src/components'; | ||
|
|
||
| const horizontalSteps: EuiStepsHorizontalProps['steps'] = [ | ||
| { | ||
| title: 'Completed step 1', | ||
| status: 'complete', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Selected step 2', | ||
| status: 'current', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Incomplete step 3 which will wrap to the next line', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Disabled step 4', | ||
| status: 'disabled', | ||
| onClick: () => {}, | ||
| }, | ||
| ]; | ||
| export default () => { | ||
| const horizontalSteps: EuiStepsHorizontalProps['steps'] = [ | ||
| { | ||
| title: 'Completed step 1', | ||
| status: 'complete', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Selected step 2', | ||
| status: 'current', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Incomplete step 3 which will wrap to the next line', | ||
| onClick: () => {}, | ||
| }, | ||
| { | ||
| title: 'Disabled step 4', | ||
| status: 'disabled', | ||
| onClick: () => {}, | ||
| }, | ||
| ]; | ||
|
|
||
| export default () => <EuiStepsHorizontal steps={horizontalSteps} />; | ||
| const sizeButtons = [ | ||
| { | ||
| id: 's', | ||
| label: 'Small', | ||
| }, | ||
| { | ||
| id: 'm', | ||
| label: 'Medium', | ||
| }, | ||
| ]; | ||
|
|
||
| const [toggleSize, setToggleSize] = useState<EuiStepsHorizontalSizes>('m'); | ||
|
|
||
| const sizeOnChange = (optionId: EuiStepsHorizontalSizes) => { | ||
| setToggleSize(optionId); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiTitle size="xxs"> | ||
| <h3>Step Size</h3> | ||
| </EuiTitle> | ||
| <EuiSpacer size="s" /> | ||
| <EuiButtonGroup | ||
| legend="Horizontal step size toggle" | ||
| options={sizeButtons} | ||
| idSelected={toggleSize} | ||
| onChange={(id) => sizeOnChange(id as EuiStepsHorizontalSizes)} | ||
| /> | ||
| <EuiStepsHorizontal steps={horizontalSteps} size={toggleSize} /> | ||
| </> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change from
stomhappens through out theEuiStepHorizontaltests and it's expected.EuiStepHorizontaluses theEuiStepNumbercomponent and before this PR, thetitleSizeprop was not being passed. That means the default size ofswas being used and now that it's been updated to match the newsizeprop,mis being passed toEuiStepNumber.