Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset EuiInMemoryTable pagination state when a search has been executed. #686

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Reset EuiInMemoryTable pagination state when a search has been executed. #686

merged 2 commits into from
Apr 18, 2018

Conversation

cjcenizal
Copy link
Contributor

Fixes #467

@cjcenizal cjcenizal force-pushed the reset-in-memory-table-pagination-on-search branch from e4e8aba to ab3424b Compare April 18, 2018 16:51
peteharverson
peteharverson approved these changes Apr 18, 2018
View reviewed changes
Copy link

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjcenizal cjcenizal force-pushed the reset-in-memory-table-pagination-on-search branch from 339bda4 to 4f747a8 Compare April 18, 2018 17:01
nreese
nreese approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjcenizal cjcenizal merged commit 64c0d7c into elastic:master Apr 18, 2018
@cjcenizal cjcenizal deleted the reset-in-memory-table-pagination-on-search branch April 18, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @nreese @peteharverson