Manual revert of #657, changelog to h2s #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevacqua
approved these changes
Apr 11, 2018
cchaos
approved these changes
Apr 11, 2018
| @@ -16,7 +16,6 @@ Here are our guidelines for updating the `CHANGELOG.md` file: | |||
| * Add a list item for each significant change in the PR: bugs that were fixed, new features, new components, or changes to the public API | |||
| * In the list item, always link to any relevant Pull Requests, commit ranges, or individual commits | |||
| * Add a short summary of what has changed, making sure it's informative to consumers who might be unaware of implementation details | |||
| * Always write these change items in past tense | |||
There was a problem hiding this comment.
This line can probably be kept in unless we want to explain it a bit more
There was a problem hiding this comment.
I figured we'd add it back in when the the changelog itself is past tense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#657 introduced some goofy grammar and got merged without review. Reverting for the moment and fixing the changelog to use H2s. If we go with past tense that's fine, but we'll prolly need to do some deeper rewriting to make it more readable.
cc @bevacqua @cchaos
Closes #659