Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSearchBar] relaxed syntax around hyphens #581

Merged
merged 1 commit into from
Mar 27, 2018
Merged

[EuiSearchBar] relaxed syntax around hyphens #581

merged 1 commit into from
Mar 27, 2018

Conversation

uboness
Copy link
Contributor

@uboness uboness commented Mar 27, 2018

Due to their commonality in object names, made it possible to use hyphens without escaping. The only caveat here is that a search term or a field name starts with a hyphen, then it'll have to be escaped with \.

Fixes: #577

@uboness uboness requested a review from nreese March 27, 2018 18:36
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

Due to their commonality in object names, made it possible to use hyphens without escaping. The only caveat here is that a search term or a field name starts with a hyphen, then it'll have to be escaped with `\`.

Fixes: #577
@uboness uboness merged commit 1b2f34b into elastic:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants