-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow EuiAccordion
state to be controlled from outside
#3240
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
EuiAccordion
state to be controlled from outside
Thanks @anishagg17 for this start. I don't think this prop quite fits the ask from the issue. The issue isn't asking to force a consistent state (here, closed), but to allow the toggling of the accordion to happen via an outside trigger. So think of a button that exist outside of the accordion that will either toggle the current state of the accordion or try to open it no matter the state, or close it no matter the state. More similar to a high-order-component (one that completely handles the state of a child component). |
OKay would make changes accordingly, can you suggest prop name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small copy changes, otherwise this looks good!
Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3240/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3240/ |
Looks like something in the example got disconnected - I'd guess its the accessibility fix. Both buttons toggle the option on/off and neither highlight. |
I have resolved the issue |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3240/ |
thanks again @anishagg17 ! |
Summary
Fixes: #2130
Sceenshot
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes