From 170716069ae483ec157c40288cc262b28a9de3ba Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 18:19:08 +0800 Subject: [PATCH 1/8] Fixed pagination example for BasicTable set up backwards --- src-docs/src/views/tables/paginated/paginated.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-docs/src/views/tables/paginated/paginated.js b/src-docs/src/views/tables/paginated/paginated.js index d658a6c3714..348c91fcb86 100644 --- a/src-docs/src/views/tables/paginated/paginated.js +++ b/src-docs/src/views/tables/paginated/paginated.js @@ -154,7 +154,7 @@ export class Table extends Component { return (
Hide per page options with{' '} From 051c3cd70cbd024a0f84b6fd7f485d45422fe941 Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 19:17:37 +0800 Subject: [PATCH 2/8] Added hidePerPageOptions to EuiInMemoryTable prop documentation --- src-docs/src/views/tables/in_memory/props_info.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src-docs/src/views/tables/in_memory/props_info.js b/src-docs/src/views/tables/in_memory/props_info.js index a4fd1999908..3a1b14c7d62 100644 --- a/src-docs/src/views/tables/in_memory/props_info.js +++ b/src-docs/src/views/tables/in_memory/props_info.js @@ -87,6 +87,8 @@ export const propsInfo = { }, pageSizeOptions: basicPropsInfo.Pagination.__docgenInfo.props.pageSizeOptions, + hidePerPageOptions: + basicPropsInfo.Pagination.__docgenInfo.props.hidePerPageOptions, }, }, }, From 6ea8976b8657d22f60fe6a45a41018c787cb98cd Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 19:25:49 +0800 Subject: [PATCH 3/8] Updated initialPageSize prop description for EuiInMemoryTable --- src-docs/src/views/tables/in_memory/props_info.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src-docs/src/views/tables/in_memory/props_info.js b/src-docs/src/views/tables/in_memory/props_info.js index 3a1b14c7d62..65616120350 100644 --- a/src-docs/src/views/tables/in_memory/props_info.js +++ b/src-docs/src/views/tables/in_memory/props_info.js @@ -80,8 +80,8 @@ export const propsInfo = { type: { name: 'number' }, }, initialPageSize: { - description: - 'Configures the default page size to show, must be one of "pageSizeOptions"', + description: `Configures the default page size to show, must be one of \`pageSizeOptions\`. Defaults to + the first page size in \`pageSizeOptions\`.`, required: false, type: { name: 'number' }, }, From 9afe8ba154f52cfbdd6cac59100d913e33dde7ce Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 19:30:02 +0800 Subject: [PATCH 4/8] Fixed typo in pagination prop description in EuiInMemoryTable --- src-docs/src/views/tables/in_memory/props_info.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-docs/src/views/tables/in_memory/props_info.js b/src-docs/src/views/tables/in_memory/props_info.js index 65616120350..8dc550818b2 100644 --- a/src-docs/src/views/tables/in_memory/props_info.js +++ b/src-docs/src/views/tables/in_memory/props_info.js @@ -36,7 +36,7 @@ export const propsInfo = { columns: basicPropsInfo.EuiBasicTable.__docgenInfo.props.columns, pagination: { description: - 'Enables/disables pagination. Can be an object that configured pagination when enabled', + 'Enables/disables pagination. Can be an object that configures pagination when enabled', required: false, type: { name: 'boolean | #Pagination' }, }, From 48804de70927cc700e4be14949c6747343d1a0a5 Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 19:41:27 +0800 Subject: [PATCH 5/8] Updated Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19bb57aec99..67cfc135a08 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,11 +9,13 @@ - Improved `EuiButtonEmpty` focus state when the `color` type is `text` ([#3135](https://github.com/elastic/eui/pull/3135)) - Added `EuiLoadingElastic` component ([#3017](https://github.com/elastic/eui/pull/3017)) - Upgraded `react-beautiful-dnd` to v13 ([#3064](https://github.com/elastic/eui/pull/3064)) +- Updated prop descriptions for `EuiInMemoryTable` ([#3136](https://github.com/elastic/eui/pull/3136)) **Bug Fixes** - Fixed bug in `EuiSuperDatePicker` to show correct values of commonly used values in relative tab ([#3106](https://github.com/elastic/eui/pull/3106)) - Fixed race condition in `EuiIcon` when switching from dynamically fetched components ([#3118](https://github.com/elastic/eui/pull/3118)) +- Fixed `Adding Pagination to a Basic Table` docs section toggle ([#3136](https://github.com/elastic/eui/pull/3136)) **Breaking changes** From d7bfdcb2626ce1c6d2f303f5a4489fdcf30047bd Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Sat, 21 Mar 2020 19:47:54 +0800 Subject: [PATCH 6/8] Updated Changelog --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 67cfc135a08..cc7d5f2dfec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,13 +9,13 @@ - Improved `EuiButtonEmpty` focus state when the `color` type is `text` ([#3135](https://github.com/elastic/eui/pull/3135)) - Added `EuiLoadingElastic` component ([#3017](https://github.com/elastic/eui/pull/3017)) - Upgraded `react-beautiful-dnd` to v13 ([#3064](https://github.com/elastic/eui/pull/3064)) -- Updated prop descriptions for `EuiInMemoryTable` ([#3136](https://github.com/elastic/eui/pull/3136)) +- Updated prop descriptions for `EuiInMemoryTable` ([#3142](https://github.com/elastic/eui/pull/3142)) **Bug Fixes** - Fixed bug in `EuiSuperDatePicker` to show correct values of commonly used values in relative tab ([#3106](https://github.com/elastic/eui/pull/3106)) - Fixed race condition in `EuiIcon` when switching from dynamically fetched components ([#3118](https://github.com/elastic/eui/pull/3118)) -- Fixed `Adding Pagination to a Basic Table` docs section toggle ([#3136](https://github.com/elastic/eui/pull/3136)) +- Fixed `Adding Pagination to a Basic Table` docs section toggle ([#3142](https://github.com/elastic/eui/pull/3142)) **Breaking changes** From 635664c2b7b990ccf6c6f62dca4ad1fb8e9e2bea Mon Sep 17 00:00:00 2001 From: Garett Tok Ern Liang <36098015+walnutdust@users.noreply.github.com> Date: Wed, 25 Mar 2020 02:11:53 +0800 Subject: [PATCH 7/8] Removed bugfix line in CHANGELOG --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc7d5f2dfec..6579bc4933d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,6 @@ - Fixed bug in `EuiSuperDatePicker` to show correct values of commonly used values in relative tab ([#3106](https://github.com/elastic/eui/pull/3106)) - Fixed race condition in `EuiIcon` when switching from dynamically fetched components ([#3118](https://github.com/elastic/eui/pull/3118)) -- Fixed `Adding Pagination to a Basic Table` docs section toggle ([#3142](https://github.com/elastic/eui/pull/3142)) **Breaking changes** From 5e996309822c8fbfcd1d8f971bf555bd52815c28 Mon Sep 17 00:00:00 2001 From: Caroline Horn <549577+cchaos@users.noreply.github.com> Date: Wed, 25 Mar 2020 19:00:57 -0400 Subject: [PATCH 8/8] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e2aa01f368..e2d8f754a7c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ ## [`master`](https://github.com/elastic/eui/tree/master) - Added `delimiter` prop to `EuiComboBox` ([#3104](https://github.com/elastic/eui/pull/3104)) -- Updated prop descriptions for `EuiInMemoryTable` ([#3142](https://github.com/elastic/eui/pull/3142)) +- Updated pagination prop descriptions for `EuiInMemoryTable` ([#3142](https://github.com/elastic/eui/pull/3142)) ## [`22.0.0`](https://github.com/elastic/eui/tree/v22.0.0)