From 320a9698a93e78579402c5ff692e3e713d146e19 Mon Sep 17 00:00:00 2001 From: rockfield Date: Thu, 13 Jun 2019 16:01:24 +0300 Subject: [PATCH 1/4] drawer heading fix --- src/components/nav_drawer/nav_drawer_flyout.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/nav_drawer/nav_drawer_flyout.js b/src/components/nav_drawer/nav_drawer_flyout.js index 98f8c04741d..b7b2d8c9cee 100644 --- a/src/components/nav_drawer/nav_drawer_flyout.js +++ b/src/components/nav_drawer/nav_drawer_flyout.js @@ -26,7 +26,7 @@ export const EuiNavDrawerFlyout = ({ return (
- + Date: Thu, 13 Jun 2019 16:05:50 +0300 Subject: [PATCH 2/4] update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b15cf081cc..89a71230678 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ - Fixed `EuiFlyout` scrolling in Safari ([#2033](https://github.com/elastic/eui/pull/2033)) - Fixed `EuiCallOut` header icon alignment ([#2006](https://github.com/elastic/eui/pull/2006)) - Fixed `EuiInMemoryTable` sort value persistence through lifecycle updates ([#2035](https://github.com/elastic/eui/pull/2035)) +- Fixed `EuiNavDrawerFlyout` heading ([#2040](https://github.com/elastic/eui/pull/2040)) **Breaking changes** From 3b5578877eb8ae4b8367ba5f9f094378e5ca0810 Mon Sep 17 00:00:00 2001 From: Philipp B Date: Fri, 14 Jun 2019 00:28:09 +0300 Subject: [PATCH 3/4] Apply suggestions from code review Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 89a71230678..93bfe949b9a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ - Fixed `EuiFlyout` scrolling in Safari ([#2033](https://github.com/elastic/eui/pull/2033)) - Fixed `EuiCallOut` header icon alignment ([#2006](https://github.com/elastic/eui/pull/2006)) - Fixed `EuiInMemoryTable` sort value persistence through lifecycle updates ([#2035](https://github.com/elastic/eui/pull/2035)) -- Fixed `EuiNavDrawerFlyout` heading ([#2040](https://github.com/elastic/eui/pull/2040)) +- Changed `EuiNavDrawerFlyout` title from `h2` to `div` ([#2040](https://github.com/elastic/eui/pull/2040)) **Breaking changes** From c7a5bc640a4c519d8005eb0e011b130e23316745 Mon Sep 17 00:00:00 2001 From: rockfield Date: Fri, 14 Jun 2019 00:30:01 +0300 Subject: [PATCH 4/4] Update CHANGELOG --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93bfe949b9a..83792bb70be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,13 +8,13 @@ - Added `magnet` glyph to `EuiIcon` ([2010](https://github.com/elastic/eui/pull/2010)) - Changed `logoAWS` SVG in `EuiIcon` to work better in dark mode ([#2036](https://github.com/elastic/eui/pull/2036)) - Converted toast components to TypeScript ([#2032](https://github.com/elastic/eui/pull/2032)) +- Changed `EuiNavDrawerFlyout` title from `h5` to `div` ([#2040](https://github.com/elastic/eui/pull/2040)) **Bug fixes** - Fixed `EuiFlyout` scrolling in Safari ([#2033](https://github.com/elastic/eui/pull/2033)) - Fixed `EuiCallOut` header icon alignment ([#2006](https://github.com/elastic/eui/pull/2006)) - Fixed `EuiInMemoryTable` sort value persistence through lifecycle updates ([#2035](https://github.com/elastic/eui/pull/2035)) -- Changed `EuiNavDrawerFlyout` title from `h2` to `div` ([#2040](https://github.com/elastic/eui/pull/2040)) **Breaking changes**