Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert observer utility components to TypeScript #2009

Merged

Conversation

pugnascotia
Copy link
Contributor

Summary

Convert the observer utility components to TypeScript. I added a dependency on @types/resize-observer-browser since ResizeObserver doesn't appear to be supported in TypeScript yet.

I checked that the examples in the docs site still worked in Chrome.

I also fixed a bug where the prop-types Babel plugin would bail on components with no props e.g.

const Foo: FunctionComponent = props => { ... }

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulled and built TS defs locally, confirmed the observers are still exported as expected.

@pugnascotia pugnascotia merged commit 2dcb20f into elastic:master Jun 7, 2019
@pugnascotia pugnascotia deleted the convert-observers-to-typescript branch June 7, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants