From 4a955ba228fc3784a6effe0d0caccaf67a9623c4 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Tue, 4 Jun 2019 09:44:50 -0500 Subject: [PATCH 1/3] callback fns are optional --- src/components/color_picker/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/color_picker/index.d.ts b/src/components/color_picker/index.d.ts index 896fe7844f6..4c15e4087f7 100644 --- a/src/components/color_picker/index.d.ts +++ b/src/components/color_picker/index.d.ts @@ -26,9 +26,9 @@ declare module '@elastic/eui' { */ interface HTMLDivElementOverrides { color: string; - onBlur: () => void; + onBlur?: () => void; onChange: (hex: string) => void; - onFocus: () => void; + onFocus?: () => void; } export type EuiColorPickerProps = CommonProps & Omit, keyof HTMLDivElementOverrides> & From c50879c6e510d6c7a657c98d96764da984978428 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Tue, 4 Jun 2019 09:55:04 -0500 Subject: [PATCH 2/3] #1993 CL entry --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aa939384164..ea585be6b34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `11.3.0`. +**Bug fixes** + +- Fixed optional definitions for `EuiColorPicker` `onBlur` and `onFocus` callbacks ([#1993](https://github.com/elastic/eui/pull/1993)) ## [`11.3.0`](https://github.com/elastic/eui/tree/v11.3.0) From c73b1e0b62ee0fd3e04433ee5b32690220a00073 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Tue, 4 Jun 2019 12:41:54 -0500 Subject: [PATCH 3/3] CL update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ea585be6b34..81e40f380cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ **Bug fixes** -- Fixed optional definitions for `EuiColorPicker` `onBlur` and `onFocus` callbacks ([#1993](https://github.com/elastic/eui/pull/1993)) +- Fixed optional TS definitions for `EuiColorPicker` `onBlur` and `onFocus` callbacks ([#1993](https://github.com/elastic/eui/pull/1993)) ## [`11.3.0`](https://github.com/elastic/eui/tree/v11.3.0)