Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle pointer events #1991

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jun 3, 2019

Fixes #1990

Setting the z-index to 1 ensures the hidden input for the toggle is the top most element and is the one to receive the pointer events.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos requested a review from thompsongl June 3, 2019 19:23
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thompsongl thompsongl merged commit 35a355b into elastic:master Jun 3, 2019
@cchaos cchaos deleted the fix-button-toggle branch June 4, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiButtonToggle isIconOnly is broken
3 participants