From 534bc646a90adad43fd7ad756d444fdd4d290d88 Mon Sep 17 00:00:00 2001 From: Theo Date: Tue, 7 May 2019 12:04:01 +0100 Subject: [PATCH 1/3] `relative_options` converted to TS --- .../super_date_picker/relative_options.test.ts | 18 ++++++++++++++++++ ...relative_options.js => relative_options.ts} | 6 +++++- 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 src/components/date_picker/super_date_picker/relative_options.test.ts rename src/components/date_picker/super_date_picker/{relative_options.js => relative_options.ts} (87%) diff --git a/src/components/date_picker/super_date_picker/relative_options.test.ts b/src/components/date_picker/super_date_picker/relative_options.test.ts new file mode 100644 index 00000000000..b6799da276f --- /dev/null +++ b/src/components/date_picker/super_date_picker/relative_options.test.ts @@ -0,0 +1,18 @@ +import { relativeUnitsFromLargestToSmallest } from './relative_options'; + +describe('relativeUnitsFromLargestToSmallest', () => { + test('relativeUnitsFromLargestToSmallest length', () => { + expect(relativeUnitsFromLargestToSmallest.length).toBe(7); + }); + test('relativeUnitsFromLargestToSmallest order', () => { + expect(relativeUnitsFromLargestToSmallest).toEqual([ + 'y', + 'M', + 'w', + 'd', + 'h', + 'm', + 's', + ]); + }); +}); diff --git a/src/components/date_picker/super_date_picker/relative_options.js b/src/components/date_picker/super_date_picker/relative_options.ts similarity index 87% rename from src/components/date_picker/super_date_picker/relative_options.js rename to src/components/date_picker/super_date_picker/relative_options.ts index 677191356cf..6d9c10a7198 100644 --- a/src/components/date_picker/super_date_picker/relative_options.js +++ b/src/components/date_picker/super_date_picker/relative_options.ts @@ -1,5 +1,9 @@ +interface RelativeOption { + text: string; + value: string; +} -export const relativeOptions = [ +export const relativeOptions: RelativeOption[] = [ { text: 'Seconds ago', value: 's' }, { text: 'Minutes ago', value: 'm' }, { text: 'Hours ago', value: 'h' }, From 909de8d21d8466ae6658cfe5071335661734f836 Mon Sep 17 00:00:00 2001 From: Theo Date: Wed, 8 May 2019 09:17:14 +0100 Subject: [PATCH 2/3] `relactive_options` Code Review --- .../date_picker/super_date_picker/relative_options.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/components/date_picker/super_date_picker/relative_options.ts b/src/components/date_picker/super_date_picker/relative_options.ts index 6d9c10a7198..435ff6d5434 100644 --- a/src/components/date_picker/super_date_picker/relative_options.ts +++ b/src/components/date_picker/super_date_picker/relative_options.ts @@ -1,9 +1,4 @@ -interface RelativeOption { - text: string; - value: string; -} - -export const relativeOptions: RelativeOption[] = [ +export const relativeOptions = [ { text: 'Seconds ago', value: 's' }, { text: 'Minutes ago', value: 'm' }, { text: 'Hours ago', value: 'h' }, From 84b0ba4aadbb2d72be50f5f10c94704fb6974937 Mon Sep 17 00:00:00 2001 From: Theo Date: Wed, 8 May 2019 09:17:31 +0100 Subject: [PATCH 3/3] `relactive_options` Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e42eac2a1e9..14fca9cf74d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Converted `relative_options` to TS ([#1921](https://github.com/elastic/eui/pull/1921)) - Added support for custom React SVG elements and external SVG URLs to `EuiIcon` ([#1924](https://github.com/elastic/eui/pull/1924)) **Bug fixes**