Fix overflow of EuiModals in Chrome and Safari #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
reviewed
Apr 30, 2019
snide
approved these changes
Apr 30, 2019
|
Scrollable in... MacOS 10.14 Chrome 74 Win 7 (VM) IE 11 |
|
Fantastic. Thanks all! Merging |
1 task
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
May 25, 2019
Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below: ### Before (Chrome `74.0`)  ### After (Chrome `74.0`)  ### After (Firefox `67.0`)  ### After (Safari `12.1.1`)  ### After (IE`11.0.9600`)  https://github.com/elastic/ingest-dev/issues/442
andrew-goldstein
added a commit
to elastic/kibana
that referenced
this pull request
May 28, 2019
## [SIEM] Fixes timeline notes overflowing the modal (#37134) Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below: ### Before (Chrome `74.0`)  ### After (Chrome `74.0`)  ### After (Firefox `67.0`)  ### After (Safari `12.1.1`)  ### After (IE`11.0.9600`)  https://github.com/elastic/ingest-dev/issues/442
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
May 28, 2019
Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below:      https://github.com/elastic/ingest-dev/issues/442
andrew-goldstein
added a commit
to elastic/kibana
that referenced
this pull request
May 28, 2019
## [SIEM] Fixes timeline notes overflowing the modal (#37134) Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below: ### Before (Chrome `74.0`)  ### After (Chrome `74.0`)  ### After (Firefox `67.0`)  ### After (Safari `12.1.1`)  ### After (IE`11.0.9600`)  https://github.com/elastic/ingest-dev/issues/442
andrew-goldstein
added a commit
to elastic/kibana
that referenced
this pull request
May 28, 2019
Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below:      https://github.com/elastic/ingest-dev/issues/442
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
## [SIEM] Fixes timeline notes overflowing the modal (elastic#37134) Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below. This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below: ### Before (Chrome `74.0`)  ### After (Chrome `74.0`)  ### After (Firefox `67.0`)  ### After (Safari `12.1.1`)  ### After (IE`11.0.9600`)  https://github.com/elastic/ingest-dev/issues/442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 74 broke our implementation of overflow scrolling in modals. This adds an extra flex layer to ensure that scrolling works.
Before
After
I have checked in:
Mac 10.14
Windows 7
Checklist
[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components