Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialPageIndex pagination prop to EuiInMemoryTable #1798

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Apr 4, 2019

Summary

Resolves #1794

Adds initialPageIndex pagination prop to EuiInMemoryTable to allow specifying the initial page of results.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode

  • Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@chrisronline
Copy link
Contributor

@chandlerprall I'm not sure this resolves #1274. That is more about parity between the pagination options available between EuiInMemoryTable and EuiBasicTable, notably pageIndex and pageSize. It'd be ideal if we could control these outside of EuiInMemoryTable (through our own state, triggered through onTableChange events) and we currently can't do it as we can't pass these props down.

@chandlerprall
Copy link
Contributor Author

@chrisronline I'll remove #1274 from this PR then 👍

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandlerprall chandlerprall merged commit 4254bd6 into elastic:master Apr 9, 2019
@chandlerprall chandlerprall deleted the feature/1794-euiinmemorytable-allow-initial-page branch April 9, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants