Elastic logos support dark mode #1562
Conversation
|
Looks like that is the old Logastash logo, and since X-Pack is going away we never touched it for a redesign. |
|
@JessSmithSup Figured 👍 If you have a chance can you link me to the latest LS one and I'll replace. |
There was a problem hiding this comment.
👍 LGTM.
These don't get added extremely frequently, but often enough that perhaps making a note about adding/using the class="euiIcon__fillNegative" class would be worthwhile for future contributors.
A possible home for that note could be either on the wiki, code comment, or added to the EUI docs description for the Elastic logos section?
| @@ -80,6 +80,10 @@ | |||
| fill: $euiColorGhost; | |||
| } | |||
|
|
|||
| .euiIcon__fillNegative { | |||
| fill: $euiColorDarkestShade; | |||
There was a problem hiding this comment.
So not fully white in dark mode?
There was a problem hiding this comment.
Yes. Just like it's not fully black in light mode. I was suprised to see the light mode was actually just darkest shade.
|
Should we just remove the X-pack logo from the docs? |
@ryankeairns Added it in both the code and the docs. |
|
Awesome, thanks! |
Probably, my guess is it's floating around there a bit though. I'll tackle that separately. |
|
Yeah I just meant from the docs themselves |
Logos now work better in dark mode.
Summary
Now applies the coloring through a class, rather than the hard coded value. They look good in most cases, but sort of call out some minor inconsistencies in these. My guess is we might have some old versions. I'll check with @JessSmithSup before merging.
Checklist
This was checked in mobileThis was checked in IE11Any props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components