Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and added some icons #1374

Merged
merged 6 commits into from
Dec 18, 2018
Merged

Updated and added some icons #1374

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39a5e11
Updated and added some icons
Dec 14, 2018
fa6138f
Fixed docs & cl
Dec 14, 2018
5ba38a4
cl fix
Dec 14, 2018
01119b1
Added unpin icon
Dec 14, 2018
6cbd21d
renamed `unpin` to `pinFilled`
Dec 17, 2018
d1c71cd
Merge branch 'master' into more-icons
cchaos Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Altered a few icons and added more: `crossInACircleFilled`, `editorRedo`, `editorUndo`, `grabHorizontal`, `minusInCircleFilled`, `plusInCircleFilled`, `sortable`, `starEmptySpace`, `starFilledSpace`, `starFilled`, `starMinusEmpty`, `starMinusFilled`, `starPlusEmpty` ([#1374](https://github.com/elastic/eui/pull/1374))

**Bug fixes**

- Only style anchor tags in `EuiText` that have no class attribute ([#1373](https://github.com/elastic/eui/pull/1373))
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/button/button_toggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class extends Component {
<div>
<EuiButtonToggle
label="Toggle Me"
iconType={this.state.toggle0On ? 'check' : 'cross'}
iconType={this.state.toggle0On ? 'starPlusEmpty' : 'starFilledSpace'}
onChange={this.onToggle0Change}
isSelected={this.state.toggle0On}
/>
Expand Down
30 changes: 22 additions & 8 deletions src-docs/src/views/icon/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const iconTypes = [
'copyClipboard',
'cross',
'crosshairs',
'crossInACircleFilled',
'database',
'document',
'dot',
Expand All @@ -49,10 +50,12 @@ const iconTypes = [
'editorHeading',
'editorItalic',
'editorLink',
'editorOrderedList',
'editorRedo',
'editorStrike',
'editorTable',
'editorUnderline',
'editorOrderedList',
'editorUndo',
'editorUnorderedList',
'email',
'empty',
Expand All @@ -71,6 +74,7 @@ const iconTypes = [
'gear',
'globe',
'grab',
'grabHorizontal',
'grid',
'heatmap',
'help',
Expand All @@ -82,14 +86,14 @@ const iconTypes = [
'indexMapping',
'indexOpen',
'indexSettings',
'inputOutput',
'inspect',
'invert',
'inputOutput',
'kqlField',
'kqlOperand',
'kqlValue',
'kqlFunction',
'kqlOperand',
'kqlSelector',
'kqlValue',
'link',
'list',
'listAdd',
Expand All @@ -101,9 +105,10 @@ const iconTypes = [
'logstashOutput',
'logstashQueue',
'mapMarker',
'merge',
'memory',
'merge',
'minusInCircle',
'minusInCircleFilled',
'node',
'number',
'offline',
Expand All @@ -113,6 +118,7 @@ const iconTypes = [
'pin',
'play',
'plusInCircle',
'plusInCircleFilled',
'popout',
'questionInCircle',
'refresh',
Expand All @@ -121,25 +127,31 @@ const iconTypes = [
'search',
'shard',
'share',
'sortable',
'sortDown',
'sortLeft',
'sortRight',
'sortUp',
'starEmpty',
'starEmptySpace',
'starFilled',
'starFilledSpace',
'starMinusEmpty',
'starMinusFilled',
'starPlusEmpty',
'starPlusFilled',
'stats',
'stop',
'stopFilled',
'storage',
'string',
'temperature',
'tableOfContents',
'tag',
'tear',
'temperature',
'trash',
'user',
'vector',
'wrench',
'visArea',
'visBarHorizontal',
'visBarVertical',
Expand All @@ -157,7 +169,9 @@ const iconTypes = [
'visText',
'visTimelion',
'visVega',
'visVisualBuilder'
'visVisualBuilder',
'wrench',
'wrench',
];

export default () => (
Expand Down
84 changes: 14 additions & 70 deletions src/components/flyout/__snapshots__/flyout.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,10 @@ exports[`EuiFlyout is rendered 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -65,18 +57,10 @@ exports[`EuiFlyout max width can be set to a custom number 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -107,18 +91,10 @@ exports[`EuiFlyout max width can be set to a custom value and measurement 1`] =
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -148,18 +124,10 @@ exports[`EuiFlyout max width can be set to a default 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -201,18 +169,10 @@ exports[`EuiFlyout size l is rendered 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -242,18 +202,10 @@ exports[`EuiFlyout size m is rendered 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -283,18 +235,10 @@ exports[`EuiFlyout size s is rendered 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down
60 changes: 14 additions & 46 deletions src/components/form/form_control_layout/__snapshots__/form_control_layout.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,10 @@ exports[`EuiFormControlLayout props clear onClick is rendered 1`] = `
height="16"
viewBox="0 0 16 16"
width="16"
xlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
>
<defs>
<path
d="M7.293 8l-4.147 4.146a.5.5 0 0 0 .708.708L8 8.707l4.146 4.147a.5.5 0 0 0 .708-.708L8.707 8l4.147-4.146a.5.5 0 0 0-.708-.708L8 7.293 3.854 3.146a.5.5 0 1 0-.708.708L7.293 8z"
id="cross-a"
/>
</defs>
<use
fill-rule="nonzero"
href="#cross-a"
<path
d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
/>
</svg>
</button>
Expand Down Expand Up @@ -87,16 +79,10 @@ exports[`EuiFormControlLayout props icon is rendered as a string 1`] = `
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
<path
d="M8.378 1.496l6.695 10.984A1 1 0 0 1 14.22 14H1.667a1 1 0 0 1-.883-1.47L6.642 1.545a1 1 0 0 1 1.736-.05zm-.853.52L1.667 13h12.552L7.525 2.016zM7.14 10.06L6.9 5.18h1.3l-.25 4.878h-.81zm.394 1.901a.61.61 0 0 1-.448-.186.606.606 0 0 1-.186-.444c0-.174.062-.323.186-.446a.614.614 0 0 1 .448-.184c.169 0 .315.06.44.182.124.122.186.27.186.448a.6.6 0 0 1-.189.446.607.607 0 0 1-.437.184z"
fill-rule="evenodd"
>
<path
d="M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z"
/>
<path
d="M7 6h1v5H7zM7 12h1v1H7z"
/>
</g>
/>
</svg>
</span>
</div>
Expand Down Expand Up @@ -127,16 +113,10 @@ exports[`EuiFormControlLayout props icon is rendered as an object 1`] = `
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
<path
d="M8.378 1.496l6.695 10.984A1 1 0 0 1 14.22 14H1.667a1 1 0 0 1-.883-1.47L6.642 1.545a1 1 0 0 1 1.736-.05zm-.853.52L1.667 13h12.552L7.525 2.016zM7.14 10.06L6.9 5.18h1.3l-.25 4.878h-.81zm.394 1.901a.61.61 0 0 1-.448-.186.606.606 0 0 1-.186-.444c0-.174.062-.323.186-.446a.614.614 0 0 1 .448-.184c.169 0 .315.06.44.182.124.122.186.27.186.448a.6.6 0 0 1-.189.446.607.607 0 0 1-.437.184z"
fill-rule="evenodd"
>
<path
d="M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z"
/>
<path
d="M7 6h1v5H7zM7 12h1v1H7z"
/>
</g>
/>
</svg>
</span>
</div>
Expand Down Expand Up @@ -166,16 +146,10 @@ exports[`EuiFormControlLayout props icon side left is rendered 1`] = `
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
<path
d="M8.378 1.496l6.695 10.984A1 1 0 0 1 14.22 14H1.667a1 1 0 0 1-.883-1.47L6.642 1.545a1 1 0 0 1 1.736-.05zm-.853.52L1.667 13h12.552L7.525 2.016zM7.14 10.06L6.9 5.18h1.3l-.25 4.878h-.81zm.394 1.901a.61.61 0 0 1-.448-.186.606.606 0 0 1-.186-.444c0-.174.062-.323.186-.446a.614.614 0 0 1 .448-.184c.169 0 .315.06.44.182.124.122.186.27.186.448a.6.6 0 0 1-.189.446.607.607 0 0 1-.437.184z"
fill-rule="evenodd"
>
<path
d="M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z"
/>
<path
d="M7 6h1v5H7zM7 12h1v1H7z"
/>
</g>
/>
</svg>
</span>
</div>
Expand Down Expand Up @@ -205,16 +179,10 @@ exports[`EuiFormControlLayout props icon side right is rendered 1`] = `
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<g
<path
d="M8.378 1.496l6.695 10.984A1 1 0 0 1 14.22 14H1.667a1 1 0 0 1-.883-1.47L6.642 1.545a1 1 0 0 1 1.736-.05zm-.853.52L1.667 13h12.552L7.525 2.016zM7.14 10.06L6.9 5.18h1.3l-.25 4.878h-.81zm.394 1.901a.61.61 0 0 1-.448-.186.606.606 0 0 1-.186-.444c0-.174.062-.323.186-.446a.614.614 0 0 1 .448-.184c.169 0 .315.06.44.182.124.122.186.27.186.448a.6.6 0 0 1-.189.446.607.607 0 0 1-.437.184z"
fill-rule="evenodd"
>
<path
d="M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z"
/>
<path
d="M7 6h1v5H7zM7 12h1v1H7z"
/>
</g>
/>
</svg>
</span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/form/form_control_layout/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
@include size($euiSizeS);
fill: $euiColorEmptyShade;
stroke: $euiColorEmptyShade;
stroke-width: 3px; // increase thickness of icon at such a small size
stroke-width: 2px; // increase thickness of icon at such a small size
}
}

Expand All @@ -38,4 +38,4 @@
@mixin euiFormControlLayout__padding($numOfIcons, $side: 'right') { // sass-lint:disable-line mixin-name-format
@include euiFormControlLayoutPadding($numOfIcons, $side: 'right');
@warn '@mixin euiFormControlLayout__padding is deprecated, please use euiFormControlLayoutPadding instead';
}
}
Loading