Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComment] Allow comment header to take a styled message color and border #7238

Closed
1Copenut opened this issue Sep 29, 2023 · 3 comments · Fixed by #7288
Closed

[EuiComment] Allow comment header to take a styled message color and border #7238

1Copenut opened this issue Sep 29, 2023 · 3 comments · Fixed by #7288
Assignees
Labels
feature request low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed

Comments

@1Copenut
Copy link
Contributor

Is your feature request related to a problem? Please describe.
@stephmilovic is working on an error styled message in EuiCommentList. She's looking for a way to be able to set a background color and border for errors or other styled messages.

Describe the solution you'd like
Ability to override the background color and border color on individual EuiCommentListItem components.

Additional context
@andreadelrio && @cee-chen discussed this with Steph and I in a Slack thread. The image attached below captures that discussion and gives an idea what the style overrides should produce.


IMG_1044

@cee-chen
Copy link
Contributor

cee-chen commented Oct 2, 2023

Quick note: the icon buttons in the top right should likely also change colors to match the background

@cee-chen cee-chen added the low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed label Oct 2, 2023
@itzabhinavarya
Copy link

Hii @cee-chen , Will you please explain this issue to me,Briefly?
I am a begineer and want to contribute,Please explain this issue.

@cee-chen
Copy link
Contributor

cee-chen commented Oct 3, 2023

@itzabhinavarya We'd recommend you take a look at the good first issues label instead. This issue is already being worked on by @breehall.

Please also make sure you take a look at our contributing to EUI wiki!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants