Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom EUI jest snapshot serializer #6676

Closed
JasonStoltz opened this issue Apr 3, 2023 · 1 comment
Closed

Custom EUI jest snapshot serializer #6676

JasonStoltz opened this issue Apr 3, 2023 · 1 comment
Assignees

Comments

@JasonStoltz
Copy link
Member

Upgrading the EUI library in Kibana can be cumbersome, as many of our components are included in snapshot tests.

We proposing that we build a custom snapshot serializer for EUI components. The goal is to avoid heavy churn when making updates in Kibana.

@JasonStoltz JasonStoltz added meta Big idea that needs refinement, grouping like tasks, no clear DoD or not a discrete piece of work roadmap labels Apr 3, 2023
@cee-chen cee-chen changed the title [Meta] Custom EUI jest snapshot serializer [Roadmap] Custom EUI jest snapshot serializer Apr 17, 2023
@cee-chen cee-chen removed the meta Big idea that needs refinement, grouping like tasks, no clear DoD or not a discrete piece of work label Apr 17, 2023
@cee-chen cee-chen changed the title [Roadmap] Custom EUI jest snapshot serializer Custom EUI jest snapshot serializer Apr 17, 2023
@cee-chen
Copy link
Contributor

Closed by #6769. At this time, this isn't an approach we can feasibly take due to LOE (although that may change in the future if Enzyme usage drops). We could investigate instead encouraging or evangelizing Kibana teams to avoid snapshot usage.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
@cee-chen cee-chen self-assigned this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants