You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
where the results' title text inherits its color from the global styles instead of the inverted color mode.
Proposed solution
portals, modals, any custom DOM
when document.createElement is used, the component creating it must get a class name with the current color mode values and apply it to the created element
theme provider
when setting colorMode and there is an existing theme context (not top level), it needs to insert a div and use that to set the color values for its children
The text was updated successfully, but these errors were encountered:
I never liked the idea of having to pass color default for components that have color inherit by default. As we can see in the following example: https://elastic.github.io/eui/#/theming/color-mode. It's not intuitive. It seems a bug in my opinion. As a user, I would expect to wrap EuiText in a color mode and it would work right away.
So I like the proposed solution:
when setting colorMode and there is an existing theme context (not top level), it needs to insert a div and use that to set the color values for its children
Having a new div can cause some layout issues. So we need to make sure this div has styles that fits different scenarios or it is easily customizable.
https://codesandbox.io/s/sweet-einstein-05j8k0
Given the setup,
we get
where the results' title text inherits its color from the global styles instead of the inverted color mode.
Proposed solution
portals, modals, any custom DOM
when
document.createElement
is used, the component creating it must get a class name with the current color mode values and apply it to the created elementtheme provider
when setting
colorMode
and there is an existing theme context (not top level), it needs to insert a div and use that to set the color values for its childrenThe text was updated successfully, but these errors were encountered: