Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range control style issues #625

Closed
yuri-tceretian opened this issue Apr 2, 2018 · 1 comment
Closed

Range control style issues #625

yuri-tceretian opened this issue Apr 2, 2018 · 1 comment

Comments

@yuri-tceretian
Copy link

yuri-tceretian commented Apr 2, 2018

  1. The range control looks disabled when it is used in a layout with more contrast controls (screenshot below).
    image
    During testing Elastic Cloud Admin UI (part of it in the screenshot) I caught myself trying to find some check\radio box to enable a slider because it looked like disabled. The control wasn't disabled but controls around it made me feel like it was. I think some contrast border for the circle handle would be great to avoid such confusion.

  2. Labels for the range control are barely readable in dark mode (see screenshot below)
    image

@cchaos
Copy link
Contributor

cchaos commented Jul 2, 2018

The styling of the range control has been fixed in #932. That should be sufficient to close this ticket. I've made a separate ticket (#960) for creating a more customizable range control like the one used in these screenshots.

@cchaos cchaos closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants