Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] shouldRenderCustomStyles account for more configurations #6152

Closed
thompsongl opened this issue Aug 22, 2022 · 1 comment · Fixed by #6248
Closed

[Testing] shouldRenderCustomStyles account for more configurations #6152

thompsongl opened this issue Aug 22, 2022 · 1 comment · Fixed by #6248

Comments

@thompsongl
Copy link
Contributor

Yeah it looks like there are a couple scenarios not accounted for in the shouldRenderCustomStyles helper.

  • When the css prop is passed to a component that already uses Emotion
  • When the style prop is not passed to the main element in the component

Looking, but we may need shouldRenderCustomStyles to accept a some kind of config object

Originally posted by @thompsongl in #6110 (comment)
@thompsongl thompsongl mentioned this issue Aug 22, 2022
Merged
11 tasks
@cee-chen
Copy link
Contributor

Totally lost track of this issue, thanks greg!

Will be resolved by #6239 and #6248.

@cee-chen cee-chen mentioned this issue Sep 20, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Emotion] Fix/regression test more css props cee-chen/eui
2 participants
@cee-chen @thompsongl