Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperSelect + EuiFormRow] Field label doesn't turn blue when item in focus #5094

Closed
brittanyjoiner15 opened this issue Aug 25, 2021 · 2 comments · Fixed by #5097
Closed
Assignees

Comments

@brittanyjoiner15
Copy link

Might be related to #5091 but also might not.

That same field label does not turn blue when active, unlike other fields.

Active field EuiSuperSelect component that we're having issues with in #5091
(black default text color on field label)
image

An active EuiSelect component on same form
(blue highlight/active text color on field label)
image

Another active EuiSuperSelect component on same form
(blue highlight/active text color on field label)
image

@chandlerprall chandlerprall changed the title Field label doesn't turn blue when item in focus [EuiSuperSelect + EuiFormRow] Field label doesn't turn blue when item in focus Aug 25, 2021
@cee-chen cee-chen self-assigned this Aug 26, 2021
@cee-chen
Copy link
Contributor

I investigated this while fixing #5091 and it's unrelated, but I was able to find a workaround after observing how EuiColorPicker maintained focus state on its label 🎉 Both fixes should be in #5097!

As a quick note, accessibility is unaffected as the focus state is where it belongs (within the popover/dropdown), so it's purely a visual bug.

@brittanyjoiner15
Copy link
Author

woohoo! thanks @constancecchen !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants